Arc++: Pref initial value issue. |
||||||||||
Issue descriptionAfter adding user control for enable Arc app sync and related prefs, an bug is introduced because un-match initial state. When user never set sync-settings, Apps and arc apps sync enable prefs stays false and thus arc package sync service is not start. This patch would fix the initial unmatch issue. https://codereview.chromium.org/2289163003/
,
Aug 31 2016
,
Aug 31 2016
Would merge to M53 together with https://bugs.chromium.org/p/chromium/issues/detail?id=641011
,
Sep 1 2016
,
Sep 1 2016
[Automated comment] Less than 2 weeks to go before stable on M53, manual review required.
,
Sep 1 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 2 2016
https://codereview.chromium.org/2304573003 M54 merged.
,
Sep 2 2016
This one also appears to be app specific, if we are going to merge the feature, we may as well merge the fix.
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c952ec6aee549b6bc34bebc9a06c8392faf6d949 commit c952ec6aee549b6bc34bebc9a06c8392faf6d949 Author: Luis Hector Chavez <lhchavez@google.com> Date: Fri Sep 02 23:04:41 2016 [Merge to M53]arc: Add arc enable sync pref initial set up. Arc enable sync pref is false by default if user never modify sync settings. This patch enables arc sync service to start when user never manually modify sync settings. BUG= 642907 , http://b/31156650 TEST=Manual test on a machine that sync settings is never modified. TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2289163003 Cr-Commit-Position: refs/heads/master@{#415748} (cherry picked from commit a9c8ea0daf53303475b32177b76938cf6b31c04d) Review URL: https://codereview.chromium.org/2311453003 . Cr-Commit-Position: refs/branch-heads/2785@{#819} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/c952ec6aee549b6bc34bebc9a06c8392faf6d949/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
,
Sep 5 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2016
,
Sep 6 2016
,
Oct 4 2016
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by lgcheng@google.com
, Aug 31 2016