New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642905 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

suite job should have an option to force to fail if no test job is created.

Project Member Reported by dshi@chromium.org, Aug 31 2016

Issue description

related to bug 642880, CQ silently pass all moblab test runs because no test was created for the suite. In this case, the suite job should fail if no test was created. An option is needed when creating the suite.
 

Comment 1 by sbasi@chromium.org, Aug 31 2016

Aviv maybe this should be an exit code for run_suite?

Comment 2 by sbasi@chromium.org, Feb 3 2017

Owner: sbasi@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b79379f47294920f8d44227e93a704e12724f05b

commit b79379f47294920f8d44227e93a704e12724f05b
Author: Simran Basi <sbasi@google.com>
Date: Wed Feb 15 21:33:10 2017

[autotest] Move MobLab image storage cleanup and ensure moblab_RunSuite runs a test.

Fixing two problems with this CL.

1) Migrates the cleanup of the moblab image storage folder
   from moblab_host to the moblab_RunSuite test.

2) Updates the moblab_RunSuite test and run_suite to ensure
   atleast a single test is ran to prevent breakages that
   create 0 tests.

BUG= chromium:671709 ,chromium:642905
TEST=None

Change-Id: Ief1567c0c1a692d4ca10735b30f49cc43776e9ed
Reviewed-on: https://chromium-review.googlesource.com/437750
Commit-Ready: Simran Basi <sbasi@chromium.org>
Tested-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/b79379f47294920f8d44227e93a704e12724f05b/site_utils/run_suite.py
[modify] https://crrev.com/b79379f47294920f8d44227e93a704e12724f05b/server/site_tests/moblab_RunSuite/moblab_RunSuite.py
[modify] https://crrev.com/b79379f47294920f8d44227e93a704e12724f05b/server/hosts/moblab_host.py

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ba90ec86aa31ac93f2eeba1f5407f0426ced508d

commit ba90ec86aa31ac93f2eeba1f5407f0426ced508d
Author: Simran Basi <sbasi@chromium.org>
Date: Fri Feb 17 06:59:08 2017

Revert "[autotest] Move MobLab image storage cleanup and ensure moblab_RunSuite runs a test."

This reverts commit b79379f47294920f8d44227e93a704e12724f05b.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [autotest] Move MobLab image storage cleanup and ensure moblab_RunSuite runs a test.
> 
> Fixing two problems with this CL.
> 
> 1) Migrates the cleanup of the moblab image storage folder
>    from moblab_host to the moblab_RunSuite test.
> 
> 2) Updates the moblab_RunSuite test and run_suite to ensure
>    atleast a single test is ran to prevent breakages that
>    create 0 tests.
> 
> BUG= chromium:671709 ,chromium:642905
> TEST=None
> 
> Change-Id: Ief1567c0c1a692d4ca10735b30f49cc43776e9ed
> Reviewed-on: https://chromium-review.googlesource.com/437750
> Commit-Ready: Simran Basi <sbasi@chromium.org>
> Tested-by: Simran Basi <sbasi@chromium.org>
> Reviewed-by: Dan Shi <dshi@google.com>
> 

TBR=sbasi@chromium.org,sbasi@google.com,dshi@google.com,dshi@chromium.org,akeshet@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG= chromium:671709 ,chromium:642905

Change-Id: Ie2f7b78fe5fd39b004436b367ab62050ae76dc1b
Reviewed-on: https://chromium-review.googlesource.com/444310
Reviewed-by: Simran Basi <sbasi@chromium.org>
Tested-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/ba90ec86aa31ac93f2eeba1f5407f0426ced508d/site_utils/run_suite.py
[modify] https://crrev.com/ba90ec86aa31ac93f2eeba1f5407f0426ced508d/server/site_tests/moblab_RunSuite/moblab_RunSuite.py
[modify] https://crrev.com/ba90ec86aa31ac93f2eeba1f5407f0426ced508d/server/hosts/moblab_host.py

Comment 5 by sbasi@chromium.org, Jul 18 2017

Labels: -Pri-2 Pri-3
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be closed. Thank you.

Sign in to add a comment