New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642902 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools intiially reports extension bg page as type "other", then later reports it as a "background_page"

Project Member Reported by samu...@chromium.org, Aug 31 2016

Issue description

I believe this started with crrev.com/414707. Before, extension background pages would get reported with "type":"background_page". Now, I'm seeing "type":"other" for the first few requests to /json, and then it changes to "type":"background_page".

Unfortunately I can only reproduce this on our buildbots, and my MacBook Air, but not my Ubuntu desktop.

Sample logs are below, note the "type" field for the generated background page.

[3.233][DEBUG]: DevTools request: http://localhost:12875/json
[3.374][DEBUG]: DevTools response: [ {
   "description": "",
   "devtoolsFrontendUrl": "/devtools/inspector.html?ws=localhost:12875/devtools/page/adf67969-5a41-4ec3-9bb6-caf8ee598ad4",
   "id": "adf67969-5a41-4ec3-9bb6-caf8ee598ad4",
   "title": "data:,",
   "type": "page",
   "url": "data:,",
   "webSocketDebuggerUrl": "ws://localhost:12875/devtools/page/adf67969-5a41-4ec3-9bb6-caf8ee598ad4"
}, {
   "description": "",
   "devtoolsFrontendUrl": "/devtools/inspector.html?ws=localhost:12875/devtools/page/495bf4ae-888c-41d0-881e-c028ccc0b7be",
   "id": "495bf4ae-888c-41d0-881e-c028ccc0b7be",
   "title": "chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/_generated_background_page.html",
   "type": "other",
   "url": "chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/_generated_background_page.html",
   "webSocketDebuggerUrl": "ws://localhost:12875/devtools/page/495bf4ae-888c-41d0-881e-c028ccc0b7be"
} ]

...and then later...

[6.968][DEBUG]: DevTools request: http://localhost:12875/json
[7.004][DEBUG]: DevTools response: [ {
   "description": "",
   "devtoolsFrontendUrl": "/devtools/inspector.html?ws=localhost:12875/devtools/page/4332e2e8-84ba-4a10-a2d2-9717758e06b8",
   "id": "4332e2e8-84ba-4a10-a2d2-9717758e06b8",
   "title": "http://localhost:4534/common/blank.html",
   "type": "page",
   "url": "http://localhost:4534/common/blank.html",
   "webSocketDebuggerUrl": "ws://localhost:12875/devtools/page/4332e2e8-84ba-4a10-a2d2-9717758e06b8"
}, {
   "description": "",
   "id": "adf67969-5a41-4ec3-9bb6-caf8ee598ad4",
   "title": "Testing Alerts",
   "type": "page",
   "url": "http://localhost:4534/common/alerts.html"
}, {
   "description": "",
   "devtoolsFrontendUrl": "/devtools/inspector.html?ws=localhost:12875/devtools/page/495bf4ae-888c-41d0-881e-c028ccc0b7be",
   "id": "495bf4ae-888c-41d0-881e-c028ccc0b7be",
   "title": "Chrome Automation Extension",
   "type": "background_page",
   "url": "chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/_generated_background_page.html",
   "webSocketDebuggerUrl": "ws://localhost:12875/devtools/page/495bf4ae-888c-41d0-881e-c028ccc0b7be"
} ]
 
Cc: pfeldman@chromium.org
Owner: ----
Status: Started (was: Untriaged)
We could work around this by discarding background pages with "type"=="other". We should probably be doing this anyway, I think we identify background pages by the URL scheme because very old versions of DevTools didn't support the "background_page" type.

Please let me know if there's a reason we shouldn't do discard background pages with type==other.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/329ded4ea587e22b0d2660bafdd3e8d98300a972

commit 329ded4ea587e22b0d2660bafdd3e8d98300a972
Author: samuong <samuong@chromium.org>
Date: Thu Sep 01 03:38:14 2016

[chromedriver] Do not identify extension background pages by url scheme.

BUG= 642902 

Review-Url: https://codereview.chromium.org/2304433002
Cr-Commit-Position: refs/heads/master@{#415873}

[modify] https://crrev.com/329ded4ea587e22b0d2660bafdd3e8d98300a972/chrome/test/chromedriver/chrome/devtools_http_client.cc

Owner: samu...@chromium.org
Status: Fixed (was: Started)
This fixes it on the chromedriver side, so I'm marking as Fixed.

Sign in to add a comment