LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated.RunMultiThread_DelegatingRenderer is flaky on Windows 7 bots |
|||
Issue descriptionThe following runs on Win7 Tets (dbg)(1) have problems: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52234 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52232 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52213 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52212 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52209 PTAL. This seems to have been added fairly recently and already produced a few failed builds.
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e16f5f83b5a634369a7e9d82fddfe2e1ec10a9d commit 1e16f5f83b5a634369a7e9d82fddfe2e1ec10a9d Author: ericrk <ericrk@chromium.org> Date: Wed Aug 31 22:56:09 2016 Fix LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test was incorrectly relying on WillBeginImplFrameOnThread only being called once after the OutputSurface was recreated. In reality, this function could be called multiple times. This patch causes us to handle cleanup in DidInitializeOutputSurface, which will only be called once after recreating an OutputSurface. BUG= 642881 , 642836 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2297413002 Cr-Commit-Position: refs/heads/master@{#415791} [modify] https://crrev.com/1e16f5f83b5a634369a7e9d82fddfe2e1ec10a9d/cc/trees/layer_tree_host_unittest.cc
,
Aug 31 2016
,
Sep 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a2b4b5a2d2a62d8f1c8fc6d86b53e561aaecd25 commit 2a2b4b5a2d2a62d8f1c8fc6d86b53e561aaecd25 Author: Eric Karl <ericrk@chromium.org> Date: Tue Sep 20 16:02:46 2016 Fix LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test was incorrectly relying on WillBeginImplFrameOnThread only being called once after the OutputSurface was recreated. In reality, this function could be called multiple times. This patch causes us to handle cleanup in DidInitializeOutputSurface, which will only be called once after recreating an OutputSurface. BUG= 642881 , 642836 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2297413002 Cr-Commit-Position: refs/heads/master@{#415791} (cherry picked from commit 1e16f5f83b5a634369a7e9d82fddfe2e1ec10a9d) Review URL: https://codereview.chromium.org/2354983002 . Cr-Commit-Position: refs/branch-heads/2840@{#440} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/2a2b4b5a2d2a62d8f1c8fc6d86b53e561aaecd25/cc/trees/layer_tree_host_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a2b4b5a2d2a62d8f1c8fc6d86b53e561aaecd25 commit 2a2b4b5a2d2a62d8f1c8fc6d86b53e561aaecd25 Author: Eric Karl <ericrk@chromium.org> Date: Tue Sep 20 16:02:46 2016 Fix LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated test was incorrectly relying on WillBeginImplFrameOnThread only being called once after the OutputSurface was recreated. In reality, this function could be called multiple times. This patch causes us to handle cleanup in DidInitializeOutputSurface, which will only be called once after recreating an OutputSurface. BUG= 642881 , 642836 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2297413002 Cr-Commit-Position: refs/heads/master@{#415791} (cherry picked from commit 1e16f5f83b5a634369a7e9d82fddfe2e1ec10a9d) Review URL: https://codereview.chromium.org/2354983002 . Cr-Commit-Position: refs/branch-heads/2840@{#440} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/2a2b4b5a2d2a62d8f1c8fc6d86b53e561aaecd25/cc/trees/layer_tree_host_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by ericrk@chromium.org
, Aug 31 2016