Issue 642878 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ manzagop@chromium.org Last visit > 30 days ago
Closed:	Sep 2016
Cc:	asvitk...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Avoid some pref writes in MetricsLog. Ensure some stability metrics are cleared.

Project Member Reported by manzagop@chromium.org, Aug 31 2016

Issue description

In MetricsLog/MetricsService:
- No need to reset pref values to 0 when they're already at 0
- No need to set stability proto values to 0 as leaving unset will be interpreted as 0 and will save bytes on the wire
- some stability metrics need to be cleared on upgrade for consistency and to avoid version misattribution

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54157007c56c2004cfd19014be6035137fb7d70d

commit 54157007c56c2004cfd19014be6035137fb7d70d
Author: manzagop <manzagop@chromium.org>
Date: Thu Sep 01 02:43:59 2016

Avoid some pref writes in MetricsLog. Ensure some stability metrics are cleared.

Also fix a typo.

BUG= 642878 

Review-Url: https://codereview.chromium.org/2294323002
Cr-Commit-Position: refs/heads/master@{#415860}

[modify] https://crrev.com/54157007c56c2004cfd19014be6035137fb7d70d/components/metrics/metrics_log.cc
[modify] https://crrev.com/54157007c56c2004cfd19014be6035137fb7d70d/components/metrics/metrics_log_unittest.cc
[modify] https://crrev.com/54157007c56c2004cfd19014be6035137fb7d70d/components/metrics/metrics_service.cc

Comment 2 by manzagop@chromium.org, Sep 1 2016

Status: Fixed (was: Untriaged)

►

Issue 642878 link

Issue metadata

Avoid some pref writes in MetricsLog. Ensure some stability metrics are cleared.

Issue description

Comment 1 by bugdroid1@chromium.org, Sep 1 2016

Comment 1 Deleted

Comment 2 by manzagop@chromium.org, Sep 1 2016

Comment 2 Deleted

Sign in to add a comment