New issue
Advanced search Search tips

Issue 642872 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 618726
Owner: ----
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

_run_finalizers spew from git cl upload recently

Project Member Reported by scottmg@chromium.org, Aug 31 2016

Issue description

I think everything still works correctly, but is somewhat annoying.

I'm not sure what the repro is, but it seems to happen on various branches, so I don't think it's Just Me?


Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit upload checks ...
  checking owners took a long time: 546ms
Done processing d:\src\cr3\src\chrome\test\base\browser_with_test_window_test.cc

** Presubmit Messages **
Missing OWNER reviewers for these files:
    chrome\test\base\browser_with_test_window_test.cc

Suggested OWNERS: (Use "git-cl owners" to interactively select owners.)
    phajdan.jr@chromium.org

Presubmit checks took 4.2s to calculate.

Presubmit checks passed.
warning: LF will be replaced by CRLF in chrome/test/data/save_page/svg.svg.
The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in third_party/WebKit/LayoutTests/mhtml/resources/mhtml_generator.py.
The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in chrome/test/data/save_page/frames-about-blank.htm.
The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in chrome/test/data/save_page/frames-xsite.htm.
The file will have its original line endings in your working directory.
 chrome/test/base/browser_with_test_window_test.cc  | 47 ++++----------------
 .../navigation_controller_impl_unittest.cc         |  2 +-
 .../browser/frame_host/navigator_impl_unittest.cc  |  2 +-
 .../browser/frame_host/render_frame_host_manager.h |  1 +
 .../render_frame_host_manager_unittest.cc          |  2 +-
 content/content_tests.gypi                         |  6 +--
 .../test/browser_side_navigation_test_utils.cc     |  4 +-
 .../test/browser_side_navigation_test_utils.h      |  6 +--
 content/public/test/test_renderer_host.cc          | 51 +++++++++++++++++++---
 content/public/test/test_renderer_host.h           | 14 +++---
 content/test/test_render_frame_host.cc             |  9 +++-
 content/test/test_render_frame_host.h              |  1 +
 content/test/test_web_contents.cc                  | 37 +++++++---------
 ...browser-side-navigation.linux.unit_tests.filter | 46 -------------------
 14 files changed, 100 insertions(+), 128 deletions(-)
This branch is associated with issue 2296483002. Adding patch to that issue.
Upload server: https://codereview.chromium.org (change with -s/--server)
Issue updated. URL: https://codereview.chromium.org/2296483002 (patchset: 240001)
Uploading base file for chrome/test/base/browser_with_test_window_test.cc

Traceback (most recent call last):
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 268, in _run_finalizers
    finalizer()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 201, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\pool.py", line 500, in _terminate_pool
    p.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\process.py", line 137, in terminate
    self._popen.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\forking.py", line 312, in terminate
    _subprocess.TerminateProcess(int(self._handle), TERMINATE)
WindowsError: [Error 5] Access is denied
Traceback (most recent call last):
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 268, in _run_finalizers
    finalizer()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 201, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\pool.py", line 500, in _terminate_pool
    p.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\process.py", line 137, in terminate
    self._popen.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\forking.py", line 312, in terminate
    _subprocess.TerminateProcess(int(self._handle), TERMINATE)
WindowsError: [Error 5] Access is denied
Traceback (most recent call last):
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 268, in _run_finalizers
    finalizer()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 201, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\pool.py", line 500, in _terminate_pool
    p.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\process.py", line 137, in terminate
    self._popen.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\forking.py", line 312, in terminate
    _subprocess.TerminateProcess(int(self._handle), TERMINATE)
WindowsError: [Error 5] Access is denied
Traceback (most recent call last):
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 268, in _run_finalizers
    finalizer()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 201, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\pool.py", line 500, in _terminate_pool
    p.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\process.py", line 137, in terminate
    self._popen.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\forking.py", line 312, in terminate
    _subprocess.TerminateProcess(int(self._handle), TERMINATE)
WindowsError: [Error 5] Access is denied
Traceback (most recent call last):
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 268, in _run_finalizers
    finalizer()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\util.py", line 201, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\pool.py", line 500, in _terminate_pool
    p.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\process.py", line 137, in terminate
    self._popen.terminate()
  File "d:\src\depot_tools\python276_bin\lib\multiprocessing\forking.py", line 312, in terminate
    _subprocess.TerminateProcess(int(self._handle), TERMINATE)
WindowsError: [Error 5] Access is denied

 

Comment 1 by grt@chromium.org, Aug 31 2016

Status: Untriaged (was: Unconfirmed)
yup, me too

Comment 2 by wfh@chromium.org, Aug 31 2016

Mergedinto: 618726
Status: Duplicate (was: Untriaged)

Sign in to add a comment