New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642838 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Omnibox shows neutral indicator for restored tab with valid HTTPS

Project Member Reported by sdy@chromium.org, Aug 31 2016

Issue description

Version: 55.0.2845.0
OS: Tested on Mac

What steps will reproduce the problem?
(1) Visit a secure page (e.g. google.com).
(2) Close the tab.
(3) Restore the tab.

What is the expected output?
Still secure.

What do you see instead?
No lock icon, dev tools says "This page is not secure" but pane otherwise indicates that it is secure. This persists across reloads.

Regression from b981f48da6fd829f0deb5dc8563b5296f8f478cb?
 

Comment 1 by sdy@chromium.org, Aug 31 2016

Forgot the screenshot.
insecure_after_restore.png
321 KB View Download

Comment 2 by jam@chromium.org, Sep 1 2016

Thanks for filing this, I just noticed this earlier today and the fix is pending review: https://codereview.chromium.org/2299843002/

Comment 3 by sdy@chromium.org, Sep 1 2016

Oh, that's great! Thanks.

Comment 4 by vakh@chromium.org, Sep 1 2016

Cc: jam@chromium.org
 Issue 643173  has been merged into this issue.
Summary: Page Security Indicators are incorrect (was: Page reported as insecure after tab restore)
Updating title per expanded repro from 643173; this bug now includes the problem that HTTP pages are shown as HTTPS and show EV certificate info from a different origin

Comment 6 by f...@chromium.org, Sep 1 2016

Labels: M-54
Since r415186 (https://codereview.chromium.org/2239273002) landed in time for the 54 cut, please merge the fix back to 54

Comment 7 by f...@chromium.org, Sep 1 2016

Components: Security>UX
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d208b90ce731f26eaadf615e082b269d753ba2d3

commit d208b90ce731f26eaadf615e082b269d753ba2d3
Author: jam <jam@chromium.org>
Date: Thu Sep 01 16:58:16 2016

Fix the page's SSL status not being set on restore.

This regressed in r415186.

Also fix it for same page navigations (i.e. user pressing enter in omnibox) since the URL might change there if the server redirects.

BUG= 642838 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2299843002
Cr-Commit-Position: refs/heads/master@{#415977}

[modify] https://crrev.com/d208b90ce731f26eaadf615e082b269d753ba2d3/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/d208b90ce731f26eaadf615e082b269d753ba2d3/content/browser/frame_host/navigation_controller_impl.cc

Comment 9 by jam@chromium.org, Sep 1 2016

felt: regarding merging, 54 branched at 414607 per chrome-team announcement so I don't think any merging needs to happen right?

Comment 10 by f...@chromium.org, Sep 1 2016

Labels: -M-54
well that shows an embarrassing failure of my mental ability to do a GT/LT operation

Comment 11 by jam@chromium.org, Sep 1 2016

Status: Fixed (was: Assigned)

Comment 12 by jleedev@gmail.com, Sep 2 2016

My report from  Issue 643173  is not fixed in 55.0.2847.0.
Confirmed #12: 643173 is not fixed in Canary 55.0.2847.0, e.g. Navigate to https://t.co/Krn2YIpDKb

Comment 14 by f...@chromium.org, Sep 2 2016

Labels: ReleaseBlock-Beta
Status: Available (was: Fixed)

Comment 15 by f...@chromium.org, Sep 2 2016

Labels: M-55

Comment 16 by jam@chromium.org, Sep 2 2016

Status: Fixed (was: Available)
I'll keep this one marked as fixed since the other bug is different, and I'll send a fix out.
Summary: Omnibox shows neutral indicator for restored tab with valid HTTPS (was: Page Security Indicators are incorrect)
Updating title to distinguish it from our many other bugs about wrong security indicators.

Comment 18 by jam@chromium.org, Sep 2 2016

Cc: f...@chromium.org maxwalker@chromium.org emilyschechter@chromium.org
 Issue 642659  has been merged into this issue.
Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label

Sign in to add a comment