New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642827 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Don't close pinned notification by the close all button

Project Member Reported by yoshiki@chromium.org, Aug 31 2016

Issue description

This is the chromium side issue of b/31022395.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d43f0e4397ca78e7eae53144c23a727b019e8ea2

commit d43f0e4397ca78e7eae53144c23a727b019e8ea2
Author: yoshiki <yoshiki@chromium.org>
Date: Wed Aug 31 18:31:18 2016

Don't close pinned notification by the close all button

Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug.

BUG=b/31022395
BUG= 642827 

Review-Url: https://codereview.chromium.org/2295923004
Cr-Commit-Position: refs/heads/master@{#415688}

[modify] https://crrev.com/d43f0e4397ca78e7eae53144c23a727b019e8ea2/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/d43f0e4397ca78e7eae53144c23a727b019e8ea2/ui/message_center/message_center_impl_unittest.cc

Labels: -Pri-3 Merge-Request-54 Pri-1

Comment 3 by dimu@chromium.org, Sep 1 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 5 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f30cd6e116fdab91a6127ae452e8f3edb78b7ed

commit 7f30cd6e116fdab91a6127ae452e8f3edb78b7ed
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Tue Sep 06 09:05:20 2016

Don't close pinned notification by the close all button

Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug.

BUG=b/31022395
BUG= 642827 

Review-Url: https://codereview.chromium.org/2295923004
Cr-Commit-Position: refs/heads/master@{#415688}
(cherry picked from commit d43f0e4397ca78e7eae53144c23a727b019e8ea2)

Review URL: https://codereview.chromium.org/2313923002 .

Cr-Commit-Position: refs/branch-heads/2840@{#164}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/7f30cd6e116fdab91a6127ae452e8f3edb78b7ed/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/7f30cd6e116fdab91a6127ae452e8f3edb78b7ed/ui/message_center/message_center_impl_unittest.cc

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Reopening as with pause the issue is still reproducible. See b/31022395
Status: Fixed (was: Assigned)
b/31022395 is not same problem. I fixed that separately.
Status: Verified (was: Fixed)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f30cd6e116fdab91a6127ae452e8f3edb78b7ed

commit 7f30cd6e116fdab91a6127ae452e8f3edb78b7ed
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Tue Sep 06 09:05:20 2016

Don't close pinned notification by the close all button

Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug.

BUG=b/31022395
BUG= 642827 

Review-Url: https://codereview.chromium.org/2295923004
Cr-Commit-Position: refs/heads/master@{#415688}
(cherry picked from commit d43f0e4397ca78e7eae53144c23a727b019e8ea2)

Review URL: https://codereview.chromium.org/2313923002 .

Cr-Commit-Position: refs/branch-heads/2840@{#164}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/7f30cd6e116fdab91a6127ae452e8f3edb78b7ed/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/7f30cd6e116fdab91a6127ae452e8f3edb78b7ed/ui/message_center/message_center_impl_unittest.cc

Sign in to add a comment