New issue
Advanced search Search tips

Issue 642824 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony [Mac] - Radio and checkbox buttons stroked in black (#000)

Project Member Reported by shrike@chromium.org, Aug 31 2016 
These buttons are stroked in black, but the spec shows a gray. This is via viewsexamples on a Retina machine.

This problem may be Retina only? It also may apply to other platforms besides the Mac.
Screen Shot 2016-08-31 at 11.14.23 AM.png
6.3 KB View Download
Screen Shot 2016-08-31 at 11.17.14 AM.png
16.3 KB View Download
Screen Shot 2016-08-31 at 11.18.55 AM.png
76.0 KB View Download

Comment 1 by ellyjo...@chromium.org, Sep 1 2016

Status: Started (was: Assigned)
They are supposed to be drawn with #5A5A5A according to the spec, but we are drawing them with [NSColor controlTextColor] which is #000000. I will swap them over to use #5A5A5A for drawing when --secondary-ui-md is set.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ba919b3d4b221fa750be368f5e94bda8372d016

commit 8ba919b3d4b221fa750be368f5e94bda8372d016
Author: ellyjones <ellyjones@chromium.org>
Date: Tue Sep 06 18:06:21 2016

macviews: always use Aura colors when --secondary-ui-md

BUG= 642824 

Review-Url: https://codereview.chromium.org/2303723003
Cr-Commit-Position: refs/heads/master@{#416668}

[modify] https://crrev.com/8ba919b3d4b221fa750be368f5e94bda8372d016/ui/native_theme/native_theme_mac.h
[modify] https://crrev.com/8ba919b3d4b221fa750be368f5e94bda8372d016/ui/native_theme/native_theme_mac.mm

Comment 4 by shrike@chromium.org, Sep 7 2016 

Looks like it's fixed.

Comment 5 by ellyjo...@chromium.org, Sep 7 2016

Status: Fixed (was: Started)
►

Sign in to add a comment