New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642821 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 643194
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 0
Type: Bug-Security



Sign in to add a comment

Global-buffer-overflow in blink::getPropertyName

Project Member Reported by ClusterFuzz, Aug 31 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5427857000235008

Fuzzer: attekett_dom_fuzzer
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: Global-buffer-overflow READ 2
Crash Address: 0x7f987a262b3e
Crash State:
  blink::getPropertyName
  blink::V8CSSStyleDeclaration::namedPropertySetterCustom
  v8::internal::PropertyCallbackArguments::Call
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=415049:415582

Minimized Testcase (0.21 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97-VVsfnUbjCC5vCq6jYatpHxAk5B8xCSytLxJZhxz8_7CPqmf3SDnLtCYtEZMa0TqQvOjQPsKHkks3hwvXpWk6z3hJ-fZPtz0hGWYuML6cbwQ2aZzI1FKIlPYGM8qqbyvVnZ0TktSkvHCLTwro1SUVZlkiZg?testcase_id=5427857000235008

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Blink>Bindings
Owner: vivekg@chromium.org
Status: Assigned (was: Untriaged)
Author: vivekg@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/4a353555d3bad654522a68a9bd410c908127ccac
Time: Thu May 14 16:29:30 2015
The CL last changed line 219 of file V8CSSStyleDeclarationCustom.cpp, which is stack frame 1.
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 1 2016

Labels: M-54
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 1 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 1 2016

Labels: Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 2 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Hi Vivek, any updates on this?  We're trying to move M54 to beta soon and it would be great to get this fixed.
Cc: vivekg@chromium.org
Labels: -Pri-1 Pri-0
Owner: haraken@chromium.org
This is top crasher on linux (150000 times a day), please take a look.
Labels: Needs-Bisect
This needs bisecting.

I don't think  https://chromium.googlesource.com/chromium/src/+/4a353555d3bad654522a68a9bd410c908127ccac is related. Note that the CL was committed 1.4 years ago.


I'm looking at the regression range but it's hard to tell the culprit :/

Cc: timloh@chromium.org
Mergedinto: 643194
Status: Duplicate (was: Assigned)
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 5 2016

Labels: -reward-topanel reward-ineligible
Project Member

Comment 13 by ClusterFuzz, Sep 6 2016

ClusterFuzz has detected this issue as fixed in range 416466:416526.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5427857000235008

Fuzzer: attekett_dom_fuzzer
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: Global-buffer-overflow READ 2
Crash Address: 0x7f987a262b3e
Crash State:
  blink::getPropertyName
  blink::V8CSSStyleDeclaration::namedPropertySetterCustom
  v8::internal::PropertyCallbackArguments::Call
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=415049:415582
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=416466:416526

Minimized Testcase (0.21 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97-VVsfnUbjCC5vCq6jYatpHxAk5B8xCSytLxJZhxz8_7CPqmf3SDnLtCYtEZMa0TqQvOjQPsKHkks3hwvXpWk6z3hJ-fZPtz0hGWYuML6cbwQ2aZzI1FKIlPYGM8qqbyvVnZ0TktSkvHCLTwro1SUVZlkiZg?testcase_id=5427857000235008

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 12 2016

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment