Shrink the minimum height of the message center |
|||||
Issue descriptionVersion: ToT OS: Chrome OS What steps will reproduce the problem? (1) Show ARC notification from Android app (2) Open the message center (3) What is the expected output? There shouldn't be a large blank between the notification and the buttons. What do you see instead? There is a blank between the notification and the buttons. Please use labels and text to provide additional information. We need to shrink the minimum height of the message center, because height of custom notifications is smaller than of chrome (non-ARC) notification.
,
Sep 13 2016
,
Sep 13 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b1762662e4bd9e65182e5d27477a87d7216fd33 commit 9b1762662e4bd9e65182e5d27477a87d7216fd33 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Tue Sep 13 07:43:13 2016 Shrink the minimum height of the message center New minimum height (77 dip) is matched for a single custom notification. BUG= 642804 Review-Url: https://codereview.chromium.org/2296863004 Cr-Commit-Position: refs/heads/master@{#417473} (cherry picked from commit e6dd1743c29c07fbbeee960f9d28f7960ab107b6) Review URL: https://codereview.chromium.org/2338723002 . Cr-Commit-Position: refs/branch-heads/2840@{#320} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9b1762662e4bd9e65182e5d27477a87d7216fd33/ui/message_center/message_center_style.h
,
Sep 13 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b1762662e4bd9e65182e5d27477a87d7216fd33 commit 9b1762662e4bd9e65182e5d27477a87d7216fd33 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Tue Sep 13 07:43:13 2016 Shrink the minimum height of the message center New minimum height (77 dip) is matched for a single custom notification. BUG= 642804 Review-Url: https://codereview.chromium.org/2296863004 Cr-Commit-Position: refs/heads/master@{#417473} (cherry picked from commit e6dd1743c29c07fbbeee960f9d28f7960ab107b6) Review URL: https://codereview.chromium.org/2338723002 . Cr-Commit-Position: refs/branch-heads/2840@{#320} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9b1762662e4bd9e65182e5d27477a87d7216fd33/ui/message_center/message_center_style.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 9 2016