New issue
Advanced search Search tips

Issue 642790 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony - missing button styles in views_examples_with_content_exe

Project Member Reported by shrike@chromium.org, Aug 31 2016

Issue description

The Harmony sticker sheet shows Harmony buttons in different styles and states, but it seems like it's not possible to see all of these styles and states in views_examples_with_content_exe?

There needs to be a Primary and Secondary button in the Default, Normal, and Disabled states (from there I get to the Hover, Pressed, and Focused states). There should be a clearly marked section (i.e. "Harmony Buttons") for these buttons, or at least the buttons should be clearly named (e.g. "Harmony Primary", etc.).
 
 

Comment 1 by shrike@chromium.org, Aug 31 2016

Blocking: 630357

Comment 2 by shrike@chromium.org, Aug 31 2016

Meant to add the button section from the Harmony style sheet. Also adding a screenshot of viewsexamples.

Screen Shot 2016-08-31 at 10.05.35 AM.png
101 KB View Download
Screen Shot 2016-08-31 at 10.13.27 AM.png
136 KB View Download
Status: Started (was: Assigned)
I uploaded https://codereview.chromium.org/2296343004/ which adds a new "Button (Sticker Sheet)" choice in the examples menu, which displays a sticker-sheet-like grid of all the Harmony buttons and their states. Screenshot attached :)
Screen Shot 2016-09-01 at 10.32.13 AM.png
40.5 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82afa6f4d9cb67ca9da0b8f32fe5dcf82c6f2bc8

commit 82afa6f4d9cb67ca9da0b8f32fe5dcf82c6f2bc8
Author: ellyjones <ellyjones@chromium.org>
Date: Fri Sep 02 16:20:31 2016

views_examples: add Button sticker sheet

This "example" displays a sticker sheet of all the available button styles,
designed to be as close as possible in appearance to the Harmony spec document's
sticker sheet.

BUG= 642790 

Review-Url: https://codereview.chromium.org/2296343004
Cr-Commit-Position: refs/heads/master@{#416280}

[modify] https://crrev.com/82afa6f4d9cb67ca9da0b8f32fe5dcf82c6f2bc8/ui/views/examples/BUILD.gn
[add] https://crrev.com/82afa6f4d9cb67ca9da0b8f32fe5dcf82c6f2bc8/ui/views/examples/button_sticker_sheet.cc
[add] https://crrev.com/82afa6f4d9cb67ca9da0b8f32fe5dcf82c6f2bc8/ui/views/examples/button_sticker_sheet.h
[modify] https://crrev.com/82afa6f4d9cb67ca9da0b8f32fe5dcf82c6f2bc8/ui/views/examples/examples_window.cc

Status: Fixed (was: Started)
The sticker sheet now has all the button styles.

Sign in to add a comment