New issue
Advanced search Search tips

Issue 642788 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 630357



Sign in to add a comment

Regression - Harmony [Mac] - Button mouse over animation is missing

Project Member Reported by shrike@chromium.org, Aug 31 2016

Issue description

I think this was collateral damage from disabling ripples? We don't want ripples but we do still want the mouse over visual change. At least I don't see it in the views_examples app.
 

Comment 1 by shrike@chromium.org, Aug 31 2016

Blocking: 630357
Was there an animation separate from changing colors?

Comment 3 by shrike@chromium.org, Aug 31 2016

I think the color change was a fade in (which I thinking was an animation).

Hm. Okay. So I'm guessing we should animate from the normal color to the hovered color or pressed color - do you know what the duration on the animation should be?
I think we just need to animate from the normal state to the hover state. This wa working correctly before we got rid of the ripples so somewhere in the ripples path is the correct animation. You should be able to find animation time from there, but better would be to just use that implementation without the ripple effect.

Comment 6 by shrike@chromium.org, Sep 23 2016

Labels: Proj-MaterialDesign-NativeUI
Labels: Proj-HarmonyControls
Labels: -M-55
M-55 clearly didn't happen.

I don't know how to triage MacViews in depth, so not changing owner/priority.  This hasn't been touched in a while; please retriage.
Status: Fixed (was: Assigned)
I just looked at this. We currently do animate between normal and hover states, and have since 5d32b67b86c16add90f6ac864d9741a959435ca1, which disabled ink drops on Mac in a more principled way. I believe this bug is now Fixed.

Sign in to add a comment