New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642782 link

Starred by 1 user
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Nov 2017
Cc:
█ flandy@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

Add additional swatches to CSS Sources

Project Member Reported by flandy@google.com, Aug 31 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Steps to reproduce the problem:
1. Open the DevTools > Sources.
2. Attempt to edit a source file with bezier values, like cubic-bezier(0.250, 0.250, 0.750, 0.750).
3. No bezier swatch or editor is available.

What is the expected behavior?
The same swatches/editors in Styles Sidebar Pane should also be available in Sources. Currently, only color swatches are available as per  crbug.com/266326 .

What went wrong?
No swatches other than color are available. 

Did this work before? No 

Chrome version: 52.0.2743.116  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by lushnikov@chromium.org, Aug 31 2016

Cc: flandy@google.com
Labels: -Type-Bug Type-Feature
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 1 2016

Labels: Hotlist-Google

Comment 5 by flandy@google.com, Sep 7 2016 

Here is how the color swatch looks when no color is set.
unsetColorSwatch.png
1.3 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3254b5dba1a5071e33db5955e131ec34ed65b864

commit 3254b5dba1a5071e33db5955e131ec34ed65b864
Author: flandy <flandy@google.com>
Date: Fri Sep 09 02:59:59 2016

DevTools: Reduce color parsing by passing in Color to ColorSwatch

Often times we are doing double work parsing color text to handle invalid
colors and then parsing color text again in setColorText. We should just
parse once and pass in the Color object to ColorSwatch.

BUG= 642782 

Review-Url: https://codereview.chromium.org/2310633002
Cr-Commit-Position: refs/heads/master@{#417488}

[modify] https://crrev.com/3254b5dba1a5071e33db5955e131ec34ed65b864/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
[modify] https://crrev.com/3254b5dba1a5071e33db5955e131ec34ed65b864/third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js
[modify] https://crrev.com/3254b5dba1a5071e33db5955e131ec34ed65b864/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/3254b5dba1a5071e33db5955e131ec34ed65b864/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
[modify] https://crrev.com/3254b5dba1a5071e33db5955e131ec34ed65b864/third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js
[modify] https://crrev.com/3254b5dba1a5071e33db5955e131ec34ed65b864/third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js

Comment 9 by lushnikov@chromium.org, Sep 15 2016

Labels: allpublic

Comment 10 by lushnikov@chromium.org, Nov 9 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment