New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642778 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Desktop Capture Picker Window Statement Is Subjunctive

Project Member Reported by qiangchen@chromium.org, Aug 31 2016

Issue description

It says "[XXX] would like to share ..."
We need to says "[XXX] wants to share ..."


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b4bb81ea09b9e553a1721ee04da67b5b61dd62c

commit 2b4bb81ea09b9e553a1721ee04da67b5b61dd62c
Author: qiangchen <qiangchen@chromium.org>
Date: Wed Aug 31 20:47:10 2016

Desktop Capture Picker Window String Change

In the major CL, I did not notice the designed actually changed
the statement a little, namely "would like" was changed to
"wants"

This CL fix this.

BUG= 602478 ,  642778 

Review-Url: https://codereview.chromium.org/2296063002
Cr-Commit-Position: refs/heads/master@{#415746}

[modify] https://crrev.com/2b4bb81ea09b9e553a1721ee04da67b5b61dd62c/chrome/app/generated_resources.grd

Status: Fixed (was: Assigned)
Labels: Merge-Request-54

Comment 4 by dimu@chromium.org, Sep 1 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 1 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8

commit cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8
Author: qiangchen <qiangchen@chromium.org>
Date: Thu Sep 01 21:40:55 2016

Desktop Capture Picker Window String Change[M54]

In the major CL, I did not notice the designed actually changed
the statement a little, namely "would like" was changed to
"wants"

This CL fix this.

BUG= 602478 ,  642778 

TBR=msw@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2296063002
Cr-Commit-Position: refs/heads/master@{#415746}
(cherry picked from commit 2b4bb81ea09b9e553a1721ee04da67b5b61dd62c)

Review-Url: https://codereview.chromium.org/2300143003
Cr-Commit-Position: refs/branch-heads/2840@{#111}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8/chrome/app/generated_resources.grd

Cc: krajshree@chromium.org
Labels: Needs-Feedback
qiangchen@ - Is there any manual test steps available to verify this issue ?
If yes, then please provide the steps to verify it from chrome-Te team.
Just open the picker dialog for desktop share. For example, hangouts' "Screen Share" functionality.

Look at the statement on the picker window, it should be

Wants.png
4.4 KB View Download
Labels: -Needs-Feedback TE-Verified-54.0.2840.14 TE-Verified-M54
Verified the issue on windows 10, Ubuntu 14.04 and Mac 10.11.6 using chrome dev version #54.0.2840.14 as per the comment #7.

Observed that the statement on the picker window is as expected.

Attaching a screenshot for reference

Thanks,
642778.png
307 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8

commit cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8
Author: qiangchen <qiangchen@chromium.org>
Date: Thu Sep 01 21:40:55 2016

Desktop Capture Picker Window String Change[M54]

In the major CL, I did not notice the designed actually changed
the statement a little, namely "would like" was changed to
"wants"

This CL fix this.

BUG= 602478 ,  642778 

TBR=msw@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2296063002
Cr-Commit-Position: refs/heads/master@{#415746}
(cherry picked from commit 2b4bb81ea09b9e553a1721ee04da67b5b61dd62c)

Review-Url: https://codereview.chromium.org/2300143003
Cr-Commit-Position: refs/branch-heads/2840@{#111}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8/chrome/app/generated_resources.grd

Sign in to add a comment