Desktop Capture Picker Window Statement Is Subjunctive |
|||||||
Issue descriptionIt says "[XXX] would like to share ..." We need to says "[XXX] wants to share ..."
,
Aug 31 2016
,
Aug 31 2016
,
Sep 1 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8 commit cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8 Author: qiangchen <qiangchen@chromium.org> Date: Thu Sep 01 21:40:55 2016 Desktop Capture Picker Window String Change[M54] In the major CL, I did not notice the designed actually changed the statement a little, namely "would like" was changed to "wants" This CL fix this. BUG= 602478 , 642778 TBR=msw@chromium.org NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2296063002 Cr-Commit-Position: refs/heads/master@{#415746} (cherry picked from commit 2b4bb81ea09b9e553a1721ee04da67b5b61dd62c) Review-Url: https://codereview.chromium.org/2300143003 Cr-Commit-Position: refs/branch-heads/2840@{#111} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8/chrome/app/generated_resources.grd
,
Sep 6 2016
qiangchen@ - Is there any manual test steps available to verify this issue ? If yes, then please provide the steps to verify it from chrome-Te team.
,
Sep 6 2016
Just open the picker dialog for desktop share. For example, hangouts' "Screen Share" functionality. Look at the statement on the picker window, it should be
,
Sep 7 2016
Verified the issue on windows 10, Ubuntu 14.04 and Mac 10.11.6 using chrome dev version #54.0.2840.14 as per the comment #7. Observed that the statement on the picker window is as expected. Attaching a screenshot for reference Thanks,
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8 commit cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8 Author: qiangchen <qiangchen@chromium.org> Date: Thu Sep 01 21:40:55 2016 Desktop Capture Picker Window String Change[M54] In the major CL, I did not notice the designed actually changed the statement a little, namely "would like" was changed to "wants" This CL fix this. BUG= 602478 , 642778 TBR=msw@chromium.org NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2296063002 Cr-Commit-Position: refs/heads/master@{#415746} (cherry picked from commit 2b4bb81ea09b9e553a1721ee04da67b5b61dd62c) Review-Url: https://codereview.chromium.org/2300143003 Cr-Commit-Position: refs/branch-heads/2840@{#111} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/cbcad42ac5afb2d0ce5da8888a3daf3a95d2f1a8/chrome/app/generated_resources.grd |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Aug 31 2016