New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642736 link

Starred by 1 user
Status: Fixed
Owner:
█ ymalik@chromium.org
(currently inactive on Chromium)
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Rename main thread scrolling reason kAnimatingOnMainThread

Project Member Reported by ymalik@chromium.org, Aug 31 2016 
This is set when the MT is initiating a smooth scroll animation which can either run on MT or the CT. kAnimatingOnMainThread implies that the animation is "running" on MT, which is not always true.

https://cs.chromium.org/chromium/src/cc/input/main_thread_scrolling_reason.h?rcl=0&l=17
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0529650b8999274d132805e0ce45d289521d24c

commit f0529650b8999274d132805e0ce45d289521d24c
Author: ymalik <ymalik@chromium.org>
Date: Fri Sep 02 16:10:17 2016

Rename kAnimatingScrollOnMainThread to kHandlingScrollFromMainThread

BUG= 642736 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2297943002
Cr-Commit-Position: refs/heads/master@{#416279}

[modify] https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c/cc/input/main_thread_scrolling_reason.h
[modify] https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-added.html
[modify] https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-correctness.html
[modify] https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
[modify] https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
[modify] https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/f0529650b8999274d132805e0ce45d289521d24c/ui/events/blink/input_handler_proxy_unittest.cc

Comment 2 by ymalik@chromium.org, Sep 2 2016

Status: Fixed (was: Started)
►

Sign in to add a comment