Tabstrip with https://codereview.chromium.org/2313723004/ applied.

Deleted: Screen Shot 2016-09-06 at 11.26.02 AM.png 31.6 KB

	Screen Shot 2016-09-06 at 11.26.02 AM.png 31.6 KB View Download

Proper RTL tab strip now.

There are some deficiencies:
1) The profile switcher is anchored to the right edge of the window even in RTL, which is Not Right (if you resize the window, it slides around the bar)
2) Tab dragging is straight-up busted - the tabs act as though they were at their real coordinates
3) The animation when creating a new tab is from the bottom right, so it looks goofy - the tab flies across the web content area
4) Closing tabs using the mouse always triggers rapid close mode, even if your mouse doesn't end up over a tab
5) I haven't tried out pinned tabs/etc

Deleted: Screen Shot 2016-09-08 at 9.45.49 AM.png 33.2 KB

	Screen Shot 2016-09-08 at 9.45.49 AM.png 33.2 KB View Download

Looking good. To add to your to do list, the favicon and close button need to switch places and the title needs to be right-aligned. And long tab titles need to fade out to the left instead of the right.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ec7f4ea9e7c48cd3a34bc1c17585a02f709c22e

commit 2ec7f4ea9e7c48cd3a34bc1c17585a02f709c22e
Author: ellyjones <ellyjones@chromium.org>
Date: Thu Sep 08 18:06:51 2016

cocoa: flip window controls and profile switcher for RTL

This change:
1) Reflects the window controls horizontally for RTL
2) Reflects the profile switcher horizontally for RTL
3) Adjusts the left and right indents for the tabstrip itself to account for
   those reflections

BUG= 642732 

Review-Url: https://codereview.chromium.org/2313723004
Cr-Commit-Position: refs/heads/master@{#417339}

[modify] https://crrev.com/2ec7f4ea9e7c48cd3a34bc1c17585a02f709c22e/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/2ec7f4ea9e7c48cd3a34bc1c17585a02f709c22e/chrome/browser/ui/cocoa/framed_browser_window.mm
[modify] https://crrev.com/2ec7f4ea9e7c48cd3a34bc1c17585a02f709c22e/chrome/browser/ui/cocoa/l10n_util.h
[modify] https://crrev.com/2ec7f4ea9e7c48cd3a34bc1c17585a02f709c22e/chrome/browser/ui/cocoa/l10n_util.mm
[modify] https://crrev.com/2ec7f4ea9e7c48cd3a34bc1c17585a02f709c22e/chrome/browser/ui/cocoa/new_tab_button.mm
[modify] https://crrev.com/2ec7f4ea9e7c48cd3a34bc1c17585a02f709c22e/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

ellyjones@ - are you landing this behind a flag? Please do that for now and let's talk again on Monday about our plan to roll out RTL support in the top chrome.

It is landed behind a flag, yes. Pass --enable-features=ExperimentalMacRTL to enable it; it's off by default.

Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4

commit e5804676b8bbf0fdd6d68cb0b6b97da0046180b4
Author: ellyjones <ellyjones@chromium.org>
Date: Fri Sep 16 13:35:05 2016

mac rtl: pin profile switcher to left edge in rtl

Otherwise, moving the right edge of the window moves the switcher. Oops.

This CL also refactors cocoa_l10n_util::ExperimentalMacRTLIsEnabled() to
include a test for base::i18n::IsRTL(), since every callsite needed to check
both.

BUG= 642732 

Review-Url: https://codereview.chromium.org/2346783002
Cr-Commit-Position: refs/heads/master@{#419155}

[modify] https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4/chrome/browser/ui/cocoa/framed_browser_window.mm
[modify] https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4/chrome/browser/ui/cocoa/l10n_util.h
[modify] https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4/chrome/browser/ui/cocoa/l10n_util.mm
[modify] https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4/chrome/browser/ui/cocoa/new_tab_button.mm
[modify] https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Handing this over to shrike@ for triage/assignment. I think there are O(weeks) of work left here.

This is not a localization bug. Can't confirm that it's still relevant to the current English UI.

Tested this on Mac OS 10.12.5 using the latest canary(61.0.3143.0) by enabling mac-rtl flag but not seeing any effect on tabstrip or Window controls.

lgrey@: Could you please review the attached screen-shot and confirm if there is still WIP and anything being missed on enabling the RTL on Mac.

Deleted: 642732.png 190 KB

	642732.png 190 KB View Download