‘Search’ icon is not highlighted even when the default focus is inside ‘Search box’.
Reported by
yfulgaon...@etouch.net,
Aug 31 2016
|
||||
Issue descriptionChrome Version : 55.0.2845.0 3a2f1b0c02f7acfc223c3f4a908f9f2e0fefc3a0-refs/heads/master@{#415522} (64-bit) OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://downloads page. 2. Observe the ’Search’ icon in search box. Actual : ‘Search’ icon is not highlighted even when the default focus is inside ‘Search box’. Expected : ‘Search’ icon should be highlighted when the default focus is inside ‘Search box’. This is a non-regression issue seen from M-55, as the ‘default focus inside search box’ is implemented in build no. 55.0.2845.0
,
Sep 4 2016
The two pages are inconsistent here, and it would be nice to make them consistent. My preference would be for History to mimic Downloads and show the icon in grey until the user starts typing.
,
Sep 5 2016
as far as I can tell from the history mocks (goo.gl/c2E8VU), the unfocused magnifying glass should be less opaque. if downloads does this by happy accident, yeah, i guess it should win
,
Sep 28 2016
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7d06665341b4829160a8c615eae591b99df19ef commit e7d06665341b4829160a8c615eae591b99df19ef Author: tsergeant <tsergeant@chromium.org> Date: Wed Sep 28 05:11:36 2016 MD History: Focus the search field on load without 'showing' it This changes the behavior from the equivalent of clicking on the search bar to the equivalent of focusing it with the tab key. This is a subtle distinction, but the end result is that the search icon does not light up, and the search field will not animate open when resizing the window into narrow mode. This CL also changes the focus logic to trigger on the correct toolbar wide mode breakpoint, which fixes an issue where the search field wouldn't be focused at certain screen widths. BUG= 642701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2369823002 Cr-Commit-Position: refs/heads/master@{#421453} [modify] https://crrev.com/e7d06665341b4829160a8c615eae591b99df19ef/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/e7d06665341b4829160a8c615eae591b99df19ef/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/e7d06665341b4829160a8c615eae591b99df19ef/chrome/test/data/webui/md_history/history_toolbar_test.js
,
Sep 28 2016
History now matches Downloads. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ranjitkan@chromium.org
, Aug 31 2016