New issue
Advanced search Search tips

Issue 642676 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

Backport RAPL energy profiling onto chromium-os v3.18 kernel

Reported by gs0...@gmail.com, Aug 31 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/51.0.2704.79 Chrome/51.0.2704.79 Safari/537.36

Steps to reproduce the problem:
perf tool supports energy profiling on x86 BDW and SKL chips, the RAPL feature provides a soft meter giving an energy outlook on various domains; BDW supports PP0/PKG/GPU/RAM while SKL supports PP0/PKG/GPU/RAM/PSYS

perf usage like:

BDW:
sudo perf stat -a -e "power/energy-cores/,power/energy-gpu/,power/energy-pkg/,power/energy-ram/" sleep 10      

SKL:
perf stat -a -e "power/energy-cores/,power/energy-gpu/,power/energy-pkg/,power/energy-ram/,power/energy-psys/" sleep 10

Initial backport in draft here:
https://chromium-review.googlesource.com/#/q/topic:rapl_enabling

What is the expected behavior?

What went wrong?
N/A, just a feature backport from upstream

Did this work before? No 

Chrome version: 51.0.2704.79  Channel: n/a
OS Version: chromium-os v3.18
Flash Version: N/A
 

Comment 1 by gs0...@gmail.com, Aug 31 2016

My bad, fat finger, kindly rename title as "RAPL enabling for BDW/SKL on chromium-os v3.18 kernel"
Components: OS>Kernel
Status: Untriaged (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 4 2016

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/9ea427237d9fe2b0bb1be1c87e0a9b33375dce8b

commit 9ea427237d9fe2b0bb1be1c87e0a9b33375dce8b
Author: Stephane Eranian <eranian@google.com>
Date: Thu Apr 23 07:07:09 2015

UPSTREAM: perf/x86/rapl: Enable Broadwell-U RAPL support

This patch enables RAPL counters (energy consumption counters)
support for Intel Broadwell-U processors (Model 61):

To use:

  $ perf stat -a -I 1000 -e power/energy-cores/,power/energy-pkg/,power/energy-ram/ sleep 10

BUG= chromium:642676 
TEST=perf stat -a -e "power/energy-cores/,power/energy-gpu/,power/energy-pkg/,power/energy-ram/" sleep 10

Signed-off-by: Stephane Eranian <eranian@google.com>
Cc: <stable@vger.kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: jacob.jun.pan@linux.intel.com
Cc: kan.liang@intel.com
Cc: peterz@infradead.org
Cc: sonnyrao@chromium.org
Link: http://lkml.kernel.org/r/20150423070709.GA4970@thinkpad
Signed-off-by: Ingo Molnar <mingo@kernel.org>
(cherry picked from commit 44b11fee51711ca85aa2b121a49bf029d18a3722)
Signed-off-by: Harry Pan <harry.pan@intel.com>

Change-Id: I2d2b07f05b5630e2caacf5ad9f2d03c96c9d8510
Reviewed-on: https://chromium-review.googlesource.com/378681
Commit-Ready: Harry Pan <harry.pan@intel.com>
Tested-by: Harry Pan <harry.pan@intel.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/9ea427237d9fe2b0bb1be1c87e0a9b33375dce8b/arch/x86/kernel/cpu/perf_event_intel_rapl.c

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/9810525a29e5444090e3d7ff8e96a5ad50080f24

commit 9810525a29e5444090e3d7ff8e96a5ad50080f24
Author: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: Wed Aug 31 09:32:27 2016

BACKPORT: perf/x86/intel/rapl: Support Skylake RAPL domains

Add Skylake client support for RAPL domains. In addition to RAPL domains
in Broadwell clients, it has support for platform domain (aka PSys). The
PSys domain controls the entire SoC instead of just a CPU package. Unlike
package domain, PSys support requires more than just processor level
implementation. The other parts in the system need additional HW level
signaling, which OEMs need to support. When not supported, the energy
counter register in PSys domain returns 0.

Also corrected error in comment for GPU counter, which previously was
DRAM counter.

BUG= chromium:642676 
TEST=perf stat -a -e "power/energy-cores/,power/energy-gpu/,power/energy-pkg/,power/energy-ram/" sleep 10

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com
[ Cnverted to model_match stuff. ]
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: bp@alien8.de
Cc: hpa@zytor.com
Cc: jacob.jun.pan@linux.intel.com
Cc: rjw@rjwysocki.net
Link: http://lkml.kernel.org/r/1460930581-29748-2-git-send-email-srinivas.pandruvada@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
(cherry picked from commit dcee75b3b7f025cc6765e6c92ba0a4e59a4d25f4)
Signed-off-by: Harry Pan <harry.pan@intel.com>

(Conflict w/ upstream because of perf event refactor in v4.6,
refer to upstream commit of 609d809f832d, this one manually
backport from v4.7 upstream of SKL enabling)

Change-Id: Ibd799460a6fbea6d24325ff04775a1c16a51d28d
Reviewed-on: https://chromium-review.googlesource.com/378682
Commit-Ready: Harry Pan <harry.pan@intel.com>
Tested-by: Harry Pan <harry.pan@intel.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

[modify] https://crrev.com/9810525a29e5444090e3d7ff8e96a5ad50080f24/arch/x86/include/uapi/asm/msr-index.h
[modify] https://crrev.com/9810525a29e5444090e3d7ff8e96a5ad50080f24/arch/x86/kernel/cpu/perf_event_intel_rapl.c

Comment 6 by gs0...@gmail.com, Sep 13 2016

Hi,

kindly correct title as "Backport RAPL energy profiling onto chromium-os v3.18 kernel".

And the patchset has been land, please advise ticket close procedure.
Status: Fixed (was: Untriaged)
Summary: Backport RAPL energy profiling onto chromium-os v3.18 kernel (was: chromium-os v3.18 kernel)

Sign in to add a comment