Regression : ‘Sad face’ is not seen at center on maximizing the browser window.
Reported by
yfulgaon...@etouch.net,
Aug 31 2016
|
||||||||||||
Issue descriptionChrome Version : 53.0.2785.89 (Official Build) a905cffb2d18baa410d0a19cc9d3941349f2d4b6-refs/branch-heads/2785@{#796} (64-bit) OS: Mac(10.10.5)(10.11.5), Windows (7,8,8.1,10),Linux (14.04 LTS) URL : chrome://chrome-signin/?access_point=0&reason=0 What steps will reproduce the problem? 1. Launch chrome, navigate to above url and resize the browser window towards LHS. 2. Open Task Manager and kill the ‘Webview: Chrome’ process. 3. Click on full screen button or Maximize the browser window, observe. Actual : ‘Sad face’ is not seen at center on maximizing the browser window. Expected : ‘Sad face’ should be seen at center on maximizing the browser window. This is a regression issue broken in M-51, below is the Manual Regression and Narrow Bisect: Good build: 51.0.2678.0 Bad build: 51.0.2678.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/c91b537eb16a73f49e61b08e8d24cfbc4649ed75..5bbfcb51bbb3dd2761a3c528177252a91f540fc3?pretty=fuller&n=10000 Suspecting: r381044 ? from Narrow Bisect @sandersd : Please help to re-assign if your change is not the cause for this issue.
,
Aug 31 2016
This is certainly not videostack related, but I have no insight as to what could be.
,
Sep 14 2016
[Bulk Edit]- Assigning to In house-HYD Team and apply label - hasbisect-per-revison If the issue still persist, try bisecting again with per-revision bisect script.
,
Sep 19 2016
Issue is still seen on mac 10.11.6 using chrome latest canary version 55.0.2865.0 Re bisected using old script and below are the details CL : https://chromium.googlesource.com/chromium/src/+log/58c2b3a90b634d71ccc8de68417789f21a59a6eb..3b10a1079a38beda8b73f86352d5867d60d6e6f6 Possible suspect : https://chromium.googlesource.com/chromium/src/+/f23d2e41c8c5024cfb8367379e50d4c143b0f55e Please reassign if this is not related to your change.
,
Sep 19 2016
This was a known issue, when I first implemented that, the only way to re-center the bitmap is to draw it at every frame, which wasn't very efficient. I think NinePatchLayer could almost work, or we could add a new type of cc layer to specifically handle this. Maybe jbauman@ has some suggestion? Either way, this is low priority.
,
Sep 19 2016
I don't know that we'd want to do too much layout in the compositor itself. Maybe we should modify the position of the sad_layer in RenderFrameProxy::frameRectsChanged or BrowserPlugin::updateGeometry.
,
Jun 16 2017
,
Jun 18 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 14
Updates: Rechecked the above issue on Mac (10.13.1, 10.13.6, 10.14.2) Windows (7,8,8.1,10),Linux (14.04 LTS) OS using latest Canary build #72.0.3609.3 and the issue not reproducible. ‘Sad face’ is seen at centre on maximising the browser window. Kindly refer the attached screen-cast. Thank You
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by yfulgaon...@etouch.net
, Aug 31 2016