New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642672 link

Starred by 1 user
Status: Fixed
Owner:
jonr...@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Background highlight is not stay for drop down icon of download shelf.

Reported by rk...@etouch.net, Aug 31 2016 
Chrome Version: 55.0.2845.0 Revision 3a2f1b0c02f7acfc223c3f4a908f9f2e0fefc3a0-refs/heads/master@{#415522}(32/64 bit)
OS:Windows (7,8,8.1,10),Linux (14.04 LTS)

Test URL: http://www.azurespeed.com/Azure/Download

What steps will reproduce the problem?
(1) Launch chrome, navigate to above url and download any file.
(2) Click on drop down icon from download shelf and observe background highlight.

Actual: Background highlight is not stay after clicking on drop down icon from download shelf.

Expected: Background highlight should stay after clicking on drop down icon from download shelf.

This is regression issue, broken in 'M-54', will soon update the other info:

Comment 1 by rk...@etouch.net, Aug 31 2016

Labels: hasbisect
Owner: jonr...@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build: 54.0.2827.0
Bad Build: 54.0.2829.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/29d9c568816f149ab93ca015971f0696ee0d4386..afe324dabcba901fcb457414a5adffac04654047?pretty=fuller&n=100

Suspecting: r411660

Note: Issue is not seen on Mac OS.
Actual_Download.mp4
603 KB View Download
Expected_Download.mp4
548 KB View Download

Comment 2 by ranjitkan@chromium.org, Aug 31 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by jonr...@chromium.org, Aug 31 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45988867f91690d8ff0d68ce52e171bf74944926

commit 45988867f91690d8ff0d68ce52e171bf74944926
Author: jonross <jonross@chromium.org>
Date: Wed Aug 31 22:18:51 2016

Download Drop Down Highlight Doesn't Stay

The highlight animations for download item views was being posted to a
non-nested loop. This allowed them to clear after returning from a blocking
menu call.

Menus do not block now. Updating the animations to register a callback
with DownloadShelfContextMenuView so that they can clear the highlight
once the menu has closed.

TEST=manually test download visuals
BUG= 642672 

Review-Url: https://codereview.chromium.org/2295323002
Cr-Commit-Position: refs/heads/master@{#415778}

[modify] https://crrev.com/45988867f91690d8ff0d68ce52e171bf74944926/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/45988867f91690d8ff0d68ce52e171bf74944926/chrome/browser/ui/views/download/download_item_view_md.cc
[modify] https://crrev.com/45988867f91690d8ff0d68ce52e171bf74944926/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc
[modify] https://crrev.com/45988867f91690d8ff0d68ce52e171bf74944926/chrome/browser/ui/views/download/download_shelf_context_menu_view.h

Comment 5 by jonr...@chromium.org, Aug 31 2016

Status: Fixed (was: Started)

Comment 6 by ranjitkan@chromium.org, Sep 8 2016

Labels: TE-Verified-55.0.2853.0 TE-Verified-M55
Rechecked this on chrome version 55.0.2853.0 on Windows 10 and Ubuntu 14.04. Fix is working as intended. Adding TE-Verified labels.

Thanks.!
►

Sign in to add a comment