Many fast/ layout tests are failing (and rebaseline-o-matic didn't rebaseline) |
||||
Issue descriptionThe following tests are failing. fast/block/basic/fieldset-stretch-to-legend.html fast/borders/fieldsetBorderRadius.html fast/css/fieldset-display-row.html fast/css/invalidation/fieldset-disabled.html fast/forms/006.html fast/forms/007.html fast/forms/focus-selection-input.html fast/forms/focus-selection-textarea.html fast/forms/validity-property.html fast/forms/fieldset/fieldset-align.html fast/forms/fieldset/fieldset-legend-padding-unclipped-fieldset-border.html fast/forms/fieldset/fieldset-with-float.html fast/forms/fieldset/float-before-fieldset.html fast/forms/fieldset/validation-in-fieldset.html fast/ruby/rubyDOM-remove-text2.html fast/text/whitespace/normal-after-nowrap-breaking.html fast/writing-mode/fieldsets.html paint/masks/fieldset-mask.html svg/custom/inline-svg-in-xhtml.xml They were marked as NeedsRebaseline at [1] but the rebaseline bot removed the entries at [2]. 1: https://crrev.com/94405829a3ffa94bff257bb14650170f7422bad0 2: https://crrev.com/85f727b16e7905e27f29e541799fe4f6aa1e13c6
,
Aug 31 2016
Can someone from Blink infra explain why Rebaseline bot didn't change tests and only updated TestExpectations for this case?
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e283632b2a3913e5159452442432053d5e72c6c0 commit e283632b2a3913e5159452442432053d5e72c6c0 Author: glebl <glebl@chromium.org> Date: Wed Aug 31 14:46:25 2016 Mark all affected tests for r409303 as NeedsManualRebaseline The rebaseline bot failed to rebase tests for https://crrev.com/409303 and only updated TestExpectations. This patch marks all those tests as NeedsManualRebaseline. BUG= 642668 NOTRY=true Review-Url: https://codereview.chromium.org/2294293002 Cr-Commit-Position: refs/heads/master@{#415628} [modify] https://crrev.com/e283632b2a3913e5159452442432053d5e72c6c0/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 31 2016
#2: Good question. One way to try to see why this happened may be to locally change expectations of those tests to NeedsRebaseline and run `webkit-patch auto-rebaseline` to reproduce. webkit-patch auto-rebaseline is supposed to download new baselines from: https://storage.googleapis.com/chromium-layout-test-archives/<builder>/results/layout-test-results/<baseline-path> For example for fast/borders/fieldsetBorderRadius.html on Mac 10.11 it should have downloaded: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11/results/layout-test-results/fast/borders/fieldsetBorderRadius-actual.txt (After downloading from all platforms, it should have consolidated the baselines and put it in https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/LayoutTests/fast/borders/fieldsetBorderRadius-expected.txt).
,
Mar 16 2017
I didn't end up reproducing this, and this bug was originally filed for some failures which were fixed a while ago; looking at the flakiness dashboard, these tests appear to generally be passing recently (with the exception of svg/custom/inline-svg-in-xhtml.xml needing to be rebaselined on Mac10.12, but that's a separate issue). https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=fast%2Fblock%2Fbasic%2Ffieldset-stretch-to-legend.html%2Cfast%2Fborders%2FfieldsetBorderRadius.html%2Cfast%2Fcss%2Ffieldset-display-row.html%2Cfast%2Fcss%2Finvalidation%2Ffieldset-disabled.html%2Cfast%2Fforms%2F006.html%2Cfast%2Fforms%2F007.html%2Cfast%2Fforms%2Ffocus-selection-input.html%2Cfast%2Fforms%2Ffocus-selection-textarea.html%2Cfast%2Fforms%2Fvalidity-property.html%2Cfast%2Fforms%2Ffieldset%2Ffieldset-align.html%2Cfast%2Fforms%2Ffieldset%2Ffieldset-legend-padding-unclipped-fieldset-border.html%2Cfast%2Fforms%2Ffieldset%2Ffieldset-with-float.html%2Cfast%2Fforms%2Ffieldset%2Ffloat-before-fieldset.html%2Cfast%2Fforms%2Ffieldset%2Fvalidation-in-fieldset.html%2Cfast%2Fruby%2FrubyDOM-remove-text2.html%2Cfast%2Ftext%2Fwhitespace%2Fnormal-after-nowrap-breaking.html%2Cfast%2Fwriting-mode%2Ffieldsets.html%2Cpaint%2Fmasks%2Ffieldset-mask.html%2Csvg%2Fcustom%2Finline-svg-in-xhtml.xml |
||||
►
Sign in to add a comment |
||||
Comment 1 by battre@chromium.org
, Aug 31 2016