New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642665 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : History Entry is still seen checked even on selecting 'Remove from History' option

Project Member Reported by mm00333...@techmahindra.com, Aug 31 2016

Issue description

Version:  55.0.2845.0
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch chrome -> Make sure you have more history ->Go to chrome://history page
(2)Now select any two alternate History Entries ->Click on 'Actions' Icon of selected First History Entry(Please refer video) 
(3)Now select 'Remove from History' option and observe Second History is still seen checked

Expected: History Entry  should not be seen checked even on selecting 'Remove from History' option
Actual: Instead History Entry is still seen checked 

This is a regression issue broken in M54.

Good Build:54.0.2830.0
Bad Build: 54.0.2831.0

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/b6678f521d7dd83c84e701140739cc3b47afe5d8..568c0b91abee4cb44fa6209d0d889b1b402997c8 

Suspecting https://codereview.chromium.org/2246033002  from changelog.

@calamity: Please confirm the issue and help in re-assigning if it is not related to your change.
 

 
Actual_History.ogv
704 KB View Download
Expected_History.ogv
687 KB View Download
Labels: OS-Mac
Able to reproduce the issue on Mac OS 10.11.6 using chrome latest Dev M55-55.0.2845.0. Observed only single entry is getting deleted from the history page when multiple entries are selected.
Components: Privacy
Status: WontFix (was: Assigned)
Can't reproduce this on tip of tree. There have been many changes to selection so one of them may have fixed this.
@Calamity : Issue is still seen on Latest Linux Build 55.0.2859.0
Attaching Video for reference

Repro Steps:
1.select any two alternate History Entries ->Click on 'Actions' Icon of selected First History Entry
2.Now select 'Remove from History' option and observe Second History is still seen checked
OnLatest55.0.2859.0Build.ogv
1.1 MB View Download
I may be missing something here, but, I would expect the other item to still be selected because you only acted on the first item by using that item's menu. (Which I assume you can do even if you have nothing selected.)

If you used the top bar that appears when you select something (the bar that has cancel/delete) then I would assume it would delete both.

Although, the top bar with cancel/delete disappears when you delete the first item using it's menu, even though the second item is still checked, so that should be a bug.
Cc: tsergeant@chromium.org lshang@chromium.org
Status: Available (was: WontFix)
Still can't repro this on ToT on my machine or a Windows 10 canary.

#5: Updating the selection data becomes more of a complicated mess than it's worth. I don't see this case being too common since the only purpose of selection is deletion.
#4: Can you please check this again on the latest canary? There have been recent changes to how selection and checkboxes work.
As per comment # 7 verified on latest build 55.0.2866.0 and am able to repro it.
Attaching video for reference
OnLatestLinuxBuild55.0.2866.0.ogv
958 KB View Download

Comment 9 by ajha@chromium.org, Sep 27 2016

calamity@: Could you please check the above attached screen-cast and update the thread accordingly. Please review the blocker label if this case should not be blocking.

Note: I could still reproduce the scenario mentioned in C#0 on Linux Ubuntu 14.04, chrome version: 55.0.2873.0 
I'm finally able to reproduce this.

Select items 1 and 3, then delete item 1 from the menu. It might be easier to reproduce on signed-out profiles, although I reproduced on both a signed-in and signed-out profile.

I think this is because by the time we try to unselect all items, the items have moved around to account for the deleted item. So we try and unselect item 3, but the selected item has moved up to position 2 and remains selected.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5da8e21e5b0a869e701797c6d854519ed5416a8

commit f5da8e21e5b0a869e701797c6d854519ed5416a8
Author: calamity <calamity@chromium.org>
Date: Thu Sep 29 07:48:32 2016

[MD History] Fix item selection when deleting via menu item.

This CL fixes an issue where an item in the history list would stay
selected when deleting via the menu item with multiple items selected.
This was happening because the unselect call would trigger against
outdated selection paths.

BUG= 642665 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2371363002
Cr-Commit-Position: refs/heads/master@{#421773}

[modify] https://crrev.com/f5da8e21e5b0a869e701797c6d854519ed5416a8/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/f5da8e21e5b0a869e701797c6d854519ed5416a8/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/f5da8e21e5b0a869e701797c6d854519ed5416a8/chrome/browser/resources/md_history/list_container.js
[modify] https://crrev.com/f5da8e21e5b0a869e701797c6d854519ed5416a8/chrome/test/data/webui/md_history/history_list_test.js

Status: Fixed (was: Available)
Labels: TE-Verified-M55 TE-Verified-55.0.2880.0
Tested the issue on windows 7, Mac 10.11.6 using chrome version 55.0.2880.0.History entry unchecked after selecting Remove from History option. Please find the attached screen cast for the same.

Adding TE-Verified labels.

Note:: Issue verified on 55.0.2879.0 for Linux as the 55.0.2880.0 build got failed for Linux due to issue 652581.

Thanks,
642665.mp4
936 KB View Download

Sign in to add a comment