New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642661 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings::Delay is seen while loading the contents of "Manage search engine" in chrome://md-settings

Reported by adha...@etouch.net, Aug 31 2016

Issue description

Chrome Version: 55.0.2845.0 (Official Build) 3a2f1b0c02f7acfc223c3f4a908f9f2e0fefc3a0-refs/heads/master@{#415522}-32/64 bit
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4).

What steps will reproduce the problem?
(1)Launch Chrome and navigate to chrome://md-settings.
(2)Click on "Manage search engine" option and observe.(Kindly refer the video)

Actual:Delay is seen while loading the contents of "Manage search engine"

Expected:No such delay should be seen while loading the contents of "Manage search engine"

This is a Regression issue broken in M-54,below is the Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/3839dbc4efacbba65f5d395301f2fecb9c58c1fa..01fae36efcb5eadacbd2fb8396456645a104876b?pretty=fuller&n=100

Suspecting:r412896?

Good build:54.0.2832.0
Bad build:54.0.2833.0

Kindly help to re-assign if your change is not the cause for this issue.
 
Actual result.mp4
285 KB View Download
Expected result.mp4
857 KB View Download
Labels: -M-54 -Type-Bug-Regression M-55 Type-Bug
Summary: MD Settings::Delay is seen while loading the contents of "Manage search engine" in chrome://md-settings (was: Regression:Delay is seen while loading the contents of "Manage search engine" in chrome://md-settings)
MD Settings is still under active development, so this isn't really a regression.

We may be able to improve the responsiveness by triggering an iron-resize when the search engines arrive, but I don't think this is critical or important for 54.


Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7466e51654d699a7e99fdca6e40c0955387be069

commit 7466e51654d699a7e99fdca6e40c0955387be069
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Sep 06 23:24:26 2016

MD Settings: Search Engine: Call iron-list notifyResize

In order to update promptly, iron-list needs to be notified
when it becomes invisible. The simplest way to do that for search engines is to observe when the list contents change.

BUG= 642661 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2300633006
Cr-Commit-Position: refs/heads/master@{#416767}

[modify] https://crrev.com/7466e51654d699a7e99fdca6e40c0955387be069/chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp
[modify] https://crrev.com/7466e51654d699a7e99fdca6e40c0955387be069/chrome/browser/resources/settings/search_engines_page/search_engines_list.js
[modify] https://crrev.com/7466e51654d699a7e99fdca6e40c0955387be069/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
[modify] https://crrev.com/7466e51654d699a7e99fdca6e40c0955387be069/chrome/browser/resources/settings/search_engines_page/search_engines_page.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment