New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642653 link

Starred by 3 users
Status: Fixed
Owner:
█ kbr@chromium.org
OOO until 2019-01-24
Closed: Sep 28
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

MIPS SIMD Arch (MSA) optimizations for WebKit modules

Reported by prashant...@imgtec.com, Aug 31 2016 
Steps to reproduce the problem:

What is the expected behavior?
WebKit performance improvement for mips target

What went wrong?
Newly adding MSA optimizations for WebKit modules

Did this work before? N/A 

Chrome version: 52.0.2743.116  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by kbr@chromium.org, Aug 31 2016

Components: Blink>WebGL

Comment 2 by kbr@chromium.org, Aug 31 2016

Status: Available (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b87fed4b772f1203c6178c5f0645b7790c61740

commit 0b87fed4b772f1203c6178c5f0645b7790c61740
Author: Prashant.Patil <Prashant.Patil@imgtec.com>
Date: Tue Sep 13 06:14:25 2016

Add MSA (MIPS SIMD Arch) optimized WebGL image conversion functions

We add following MSA optimized WebGL image conversion functions:
- unpackOneRowOfBGRA8LittleToRGBA8MSA
- unpackOneRowOfRGBA4444ToRGBA8MSA
- packOneRowOfRGBA8LittleToRGBA8MSA
- packOneRowOfRGBA8ToUnsignedShort5551MSA
- packOneRowOfRGBA8ToUnsignedShort565MSA

BUG= 642653 

Review-Url: https://codereview.chromium.org/2304183002
Cr-Commit-Position: refs/heads/master@{#418183}

[modify] https://crrev.com/0b87fed4b772f1203c6178c5f0645b7790c61740/third_party/WebKit/Source/platform/cpu/mips/CommonMacrosMSA.h
[modify] https://crrev.com/0b87fed4b772f1203c6178c5f0645b7790c61740/third_party/WebKit/Source/platform/graphics/cpu/mips/WebGLImageConversionMSA.h
[modify] https://crrev.com/0b87fed4b772f1203c6178c5f0645b7790c61740/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0abe2d40fdea1cb5d3ad46d7cfb2b6a95798253b

commit 0abe2d40fdea1cb5d3ad46d7cfb2b6a95798253b
Author: Prashant.Patil <Prashant.Patil@imgtec.com>
Date: Wed Sep 14 04:33:27 2016

Add WebGLImageConversionTest

We add WebGLImageConversionTest in blink_platform_unittests.
This covers following conversion tests:
- ConvertRGBA4444toRGBA8
- ConvertRGBA5551toRGBA8
- ConvertRGBA8toRA8
- convertBGRA8toRGBA8
- ConvertRGBA8toR8
- ConvertRGBA8toRGBA8
- ConvertRGBA8ToUnsignedShort4444
- ConvertRGBA8ToRGBA5551
- ConvertRGBA8ToRGB565

R=kbr@chromium.org
BUG= 642653 

Review-Url: https://codereview.chromium.org/2333233002
Cr-Commit-Position: refs/heads/master@{#418486}

[modify] https://crrev.com/0abe2d40fdea1cb5d3ad46d7cfb2b6a95798253b/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/0abe2d40fdea1cb5d3ad46d7cfb2b6a95798253b/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/0abe2d40fdea1cb5d3ad46d7cfb2b6a95798253b/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h
[add] https://crrev.com/0abe2d40fdea1cb5d3ad46d7cfb2b6a95798253b/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversionTest.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf80638fb01383b66356beda41e32fb1318cc23a

commit cf80638fb01383b66356beda41e32fb1318cc23a
Author: Prashant.Patil <Prashant.Patil@imgtec.com>
Date: Wed Oct 05 07:21:21 2016

Add MSA (MIPS SIMD Arch) optimized color conversion functions

We add following MSA optimized WebGL color conversion functions -
- packOneRowOfRGBA8ToUnsignedShort4444MSA (Gain 8x)
- packOneRowOfRGBA8LittleToR8MSA (Gain 3.5x)
- packOneRowOfRGBA8LittleToRA8MSA (Gain 4x)

R=kbr@chromium.org
BUG= 642653 

Review-Url: https://codereview.chromium.org/2392443003
Cr-Commit-Position: refs/heads/master@{#423098}

[modify] https://crrev.com/cf80638fb01383b66356beda41e32fb1318cc23a/third_party/WebKit/Source/platform/cpu/mips/CommonMacrosMSA.h
[modify] https://crrev.com/cf80638fb01383b66356beda41e32fb1318cc23a/third_party/WebKit/Source/platform/graphics/cpu/mips/WebGLImageConversionMSA.h
[modify] https://crrev.com/cf80638fb01383b66356beda41e32fb1318cc23a/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07dceb76cfef62e581b2f9bb9c25b41746af07fc

commit 07dceb76cfef62e581b2f9bb9c25b41746af07fc
Author: Prashant.Patil <Prashant.Patil@imgtec.com>
Date: Wed Oct 05 07:40:17 2016

Add MSA (MIPS SIMD Arch) optimized matrix transforms functions

We add following transform matrix MSA optimized functions
- inverse (Gain 1.3x)
- multiply (Gain 3x)

R=kbr@chromium.org
BUG= 642653 

Review-Url: https://codereview.chromium.org/2392493002
Cr-Commit-Position: refs/heads/master@{#423101}

[modify] https://crrev.com/07dceb76cfef62e581b2f9bb9c25b41746af07fc/third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95d7e1276aed8f2d2687de388d83919b813c78dc

commit 95d7e1276aed8f2d2687de388d83919b813c78dc
Author: Prashant.Patil <Prashant.Patil@imgtec.com>
Date: Thu Oct 13 07:43:02 2016

Add MSA (MIPS SIMD Arch) optimized VectorMath functions

We add following MSA optimized VectorMath functions:
- vsma
- vsmul
- vadd
- vmul
- vmaxmgv
- vclip

R=kbr@chromium.org
BUG= 642653 

Review-Url: https://codereview.chromium.org/2340583003
Cr-Commit-Position: refs/heads/master@{#424977}

[modify] https://crrev.com/95d7e1276aed8f2d2687de388d83919b813c78dc/third_party/WebKit/Source/platform/audio/VectorMath.cpp
[modify] https://crrev.com/95d7e1276aed8f2d2687de388d83919b813c78dc/third_party/WebKit/Source/platform/cpu/mips/CommonMacrosMSA.h
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f01ff879e2fcfe37eb9c873d045d96600229e88

commit 4f01ff879e2fcfe37eb9c873d045d96600229e88
Author: Prashant.Patil <Prashant.Patil@imgtec.com>
Date: Sun Feb 05 02:14:43 2017

Add clang build fix for MSA

Fixed clang build error in WebKit. Protected unused function adjoint

R=kbr@chromium.org
BUG= 642653 

Review-Url: https://codereview.chromium.org/2663983003
Cr-Commit-Position: refs/heads/master@{#448164}

[modify] https://crrev.com/4f01ff879e2fcfe37eb9c873d045d96600229e88/third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ad62979b19060ea47508a60b9eb8275bdd26330

commit 2ad62979b19060ea47508a60b9eb8275bdd26330
Author: Prashant Patil <prashant.patil@imgtec.com>
Date: Wed Oct 11 04:38:23 2017

Add build fixes for MSA in WebKit

R=kbr@chromium.org

Bug:  642653 
Change-Id: I251d1a525d15fe08c08cfa80adcc679e418a8083
Reviewed-on: https://chromium-review.googlesource.com/704575
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507890}
[modify] https://crrev.com/2ad62979b19060ea47508a60b9eb8275bdd26330/third_party/WebKit/Source/platform/audio/VectorMath.cpp
[modify] https://crrev.com/2ad62979b19060ea47508a60b9eb8275bdd26330/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp

Comment 11 by kbr@chromium.org, Sep 28

Owner: kbr@chromium.org
Status: Fixed (was: Available)
Thanks for these contributions. Since this bug hasn't been touched in a while closing it as fixed.
►

Sign in to add a comment