Regression: [MD Settings] Unnecessary focus is seen on disabled element after clicking on it.
Reported by
dchau...@etouch.net,
Aug 31 2016
|
||||||||||
Issue descriptionChrome Version: 53.0.2785.89 (Official Build) a905cffb2d18baa410d0a19cc9d3941349f2d4b6-refs/branch-heads/2785@{#796} 32/64-bit. OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4). What steps will reproduce the problem? 1. Launch chrome and sign in to browser with the account that has encrypted sync passphrase set. 2. Navigate to chrome://md-settings/syncSetup, enter passphrase in Passphrase textbox and click on 'Submit' button. 3. Click on second radio button (All data was encrypted with your sync passphrase) under 'Encryption options' and observe. Unnecessary focus is seen on second radio button after clicking on it even it's disabled. Focus should not seen on second radio button after clicking on it when it's disabled. This is a regression issue, broken in M-53 series, below is bisect info. Good build: 53.0.2748.0 Bad build: 53.0.2749.0 Unable to provide narrow bisect info as unable to sign in to Chromium build hence providing the Change log URL. Change Log URL: https://chromium.googlesource.com/chromium/src/+log/53.0.2748.0..53.0.2749.0?pretty=fuller&n=10000 Suspecting: r395948 or r396045 or r395774 Kindly help to reassign, if your changes are not related to this issue. Kindly review the attached screen-cast for reference.
,
Sep 28 2016
tommycli@ who's the most relevant person to know whether we are ok with this regression or not? The regression must've been happened with a Polymer update. The current behavior of paper-radio-group is to focus the selected item whether disabled or not. https://jsfiddle.net/mhahmadi/zne6fph7/ https://github.com/PolymerElements/iron-menu-behavior/blob/master/iron-menu-behavior.html#L285
,
Oct 3 2016
,
Nov 14 2016
,
Nov 14 2016
Marking this as available.
,
Nov 15 2016
,
Jan 7 2017
yeah, disable radios (and other things) probably shouldn't participate in the tab order or show focus notifications https://jsfiddle.net/d6vgaynt/
,
Jan 7 2017
,
Jan 7 2017
,
Feb 23 2017
Looking into this
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff422bf9533a5d53cf46d1b7309905c1b1b441ba commit ff422bf9533a5d53cf46d1b7309905c1b1b441ba Author: hcarmona <hcarmona@chromium.org> Date: Tue Apr 04 23:24:53 2017 IronMenuBehavior roll from 1.1.10 -> 1.3.0 BUG= 642644 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2794823005 Cr-Commit-Position: refs/heads/master@{#461891} [modify] https://crrev.com/ff422bf9533a5d53cf46d1b7309905c1b1b441ba/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/ff422bf9533a5d53cf46d1b7309905c1b1b441ba/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/bower.json [modify] https://crrev.com/ff422bf9533a5d53cf46d1b7309905c1b1b441ba/third_party/polymer/v1_0/components-chromium/iron-menu-behavior/iron-menu-behavior-extracted.js [modify] https://crrev.com/ff422bf9533a5d53cf46d1b7309905c1b1b441ba/third_party/polymer/v1_0/components_summary.txt
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d9d2432508df3c21fec9178132362c52023dae2 commit 4d9d2432508df3c21fec9178132362c52023dae2 Author: hcarmona <hcarmona@chromium.org> Date: Wed Apr 05 00:30:38 2017 MD-Settings A11y: Disable radio list if all options are disabled. BUG= 642644 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2715763002 Cr-Commit-Position: refs/heads/master@{#461915} [modify] https://crrev.com/4d9d2432508df3c21fec9178132362c52023dae2/chrome/browser/resources/settings/people_page/sync_page.html
,
Apr 5 2017
This should be fixed now.
,
Apr 5 2017
\o/ |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dbeam@chromium.org
, Sep 15 2016Owner: mahmadi@chromium.org