New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642643 link

Starred by 2 users
Status: Fixed
Owner:
michae...@chromium.org
Closed: Sep 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : 'Other' text is seen misplaced in chrome://md-settings page

Reported by mni...@etouch.net, Aug 31 2016 
Version: 55.0.2845.0 3a2f1b0c02f7acfc223c3f4a908f9f2e0fefc3a0-refs/heads/master@{#415522} (64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/
2. Now click on 'Show home button' check box and observe 'Other' radio button

Actual: 'Other' text is seen misplaced
Expected: 'Other' text should be seen properly

This is regression issue, broken in ‘M 55’ will soon update other info
Actual_video.mov
1.7 MB Download
Expected_video.mov
1.8 MB Download

Comment 1 by mni...@etouch.net, Aug 31 2016

Labels: hasbisect
Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)
This is regression issue, broken in ‘M 55’ and below is manual regression and narrow bisect info:
Good build : 55.0.2844.0
Bad build : 55.0.2845.0

Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/e5a4384de1d67657590646b306c6e66746f1174b..9fdc7e10d5e08818fd54a1e7a1d868b0ff8b20dd?pretty=fuller&n=100

Suspecting: r415049 ? from Narrow bisect

@michaelpg : Could you please help to reassign if your change is not the cause for this change.

Comment 2 by michae...@chromium.org, Sep 1 2016

Labels: -OS-Linux -OS-Windows -OS-Mac OS-All
Status: Started (was: Assigned)
Thanks, the bisect was really helpful. I accidentally removed no-label-float on a <settings-input> while updating dropdown menus.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c80e40aa9092c5980b86265da5620a299cc06fc1

commit c80e40aa9092c5980b86265da5620a299cc06fc1
Author: michaelpg <michaelpg@chromium.org>
Date: Thu Sep 01 20:33:32 2016

MD Settings: Fix input label spacing

In https://codereview.chromium.org/2224613003 I changed how
settings-dropdown-menu worked; in the process I accidentally an attribute
on an unrelated settings-input.

BUG= 642643 
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2305513002
Cr-Commit-Position: refs/heads/master@{#416036}

[modify] https://crrev.com/c80e40aa9092c5980b86265da5620a299cc06fc1/chrome/browser/resources/settings/appearance_page/appearance_page.html

Comment 4 by michae...@chromium.org, Sep 20 2016

Status: Fixed (was: Started)
Vertical alignment fixed. It's still not perfectly aligned, but that's a general polish issue.
►

Sign in to add a comment