New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642642 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Toggle container is not proper for Arabic language.

Reported by dmascare...@etouch.net, Aug 31 2016

Issue description

Version:55.0.2845.0 (Official Build) 3a2f1b0c02f7acfc223c3f4a908f9f2e0fefc3a0-refs/heads/master@{#415522}
OS: Windows(7,8,10)

Pre-condition: Change the browser language to Arabic.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/passwords
2. Disable the toggle container and observe.

Actual:Toggle container is not seen proper
Expected:Toggle container should be proper seen after step 2.

This is regression issue, broken in 'M 55' and below is narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/ffd1c2b2f21dd9f4e85dc6895354b3409c3385e3..6ca3509c51fc968a89314a5b59e8a3674d4a77f4?pretty=fuller&n=1000

Suspecting: r415443 ?

Good build:55.0.2844.0
Bad build:55.0.2845.0 

Note: Issue is not seen on Linux and Mac OS.
 
Actual_slider.png
91.8 KB View Download
Exp_slider.png
104 KB View Download
Labels: Proj-MaterialDesign-WebUI
Status: Started (was: Assigned)
CL at https://codereview.chromium.org/2317403004/
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e97f5450b97c632730dc2b255599568c4198c5e8

commit e97f5450b97c632730dc2b255599568c4198c5e8
Author: dschuyler <dschuyler@chromium.org>
Date: Mon Sep 12 18:35:59 2016

[MD settings] align toggle buttons in rtl

This CL adjusts the paper toggle components to that they layout well in
ltr and rtl.

BUG= 642642 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2317403004
Cr-Commit-Position: refs/heads/master@{#417981}

[modify] https://crrev.com/e97f5450b97c632730dc2b255599568c4198c5e8/chrome/browser/resources/settings/settings_vars_css.html

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e97f5450b97c632730dc2b255599568c4198c5e8

commit e97f5450b97c632730dc2b255599568c4198c5e8
Author: dschuyler <dschuyler@chromium.org>
Date: Mon Sep 12 18:35:59 2016

[MD settings] align toggle buttons in rtl

This CL adjusts the paper toggle components to that they layout well in
ltr and rtl.

BUG= 642642 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2317403004
Cr-Commit-Position: refs/heads/master@{#417981}

[modify] https://crrev.com/e97f5450b97c632730dc2b255599568c4198c5e8/chrome/browser/resources/settings/settings_vars_css.html

Status: Fixed (was: Started)

Sign in to add a comment