New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642629 link

Starred by 1 user
Status: Fixed
Owner:
█ bauerb@chromium.org
Not on Chrome anymore
Closed: May 2018
Cc:
█ dmaclach@chromium.org
█ bauerb@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-09-15
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram ClearPluginData.time is unmapped

Project Member Reported by ricea@chromium.org, Aug 31 2016 
The histogram 'ClearPluginData.time' is present in Chromium source code but
does not appear in histograms.xml. This means that data is collected for the
histogram but nothing useful is done with it.

The histogram was defined in content/browser/plugin_data_remover_impl.cc at
line 224.

https://cs.chromium.org/chromium/src/content/browser/plugin_data_remover_impl.cc?l=224

It may have moved by the time you read this.

Please remove the histogram 'ClearPluginData.time' from the source code. If
it was very recently added, it may be worth adding it to histograms.xml
instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 31 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by mpear...@chromium.org, Aug 31 2017

NextAction: 2017-09-15
Owner: bauerb@chromium.org
Status: Assigned (was: Untriaged)
bauerb@, do you know if this histogram is of any interest?  If not, please remove it.

Comment 3 by monor...@bugs.chromium.org, Sep 15 2017 

The NextAction date has arrived: 2017-09-15

Comment 4 by ricea@chromium.org, May 10 2018 

bauerb@, please remove the histogram.

Comment 5 by bauerb@chromium.org, May 10 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a21b01e4ef8c681e46c591be2a4aa093095bb973

commit a21b01e4ef8c681e46c591be2a4aa093095bb973
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Wed May 16 10:11:27 2018

Remove ClearPluginData.time histogram from PluginDataRemover

The histogram was never mapped in histograms.xml, so nothing useful
has been done with it.

Bug:  642629 
Change-Id: I1ad0158929f3367e876ec7d74f536238c53db949
Reviewed-on: https://chromium-review.googlesource.com/1054072
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559030}
[modify] https://crrev.com/a21b01e4ef8c681e46c591be2a4aa093095bb973/content/browser/plugin_data_remover_impl.cc

Comment 7 by bauerb@chromium.org, May 16 2018

Status: Fixed (was: Started)
►

Sign in to add a comment