New issue
Advanced search Search tips

Issue 642628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Extensions.DeclarativeWebRequestNetworkDelay is unmapped

Project Member Reported by ricea@chromium.org, Aug 31 2016

Issue description

The histogram 'Extensions.DeclarativeWebRequestNetworkDelay' is present in
Chromium source code but does not appear in histograms.xml. This means that
data is collected for the histogram but nothing useful is done with it.

The histogram was defined in
extensions/browser/api/web_request/web_request_api.cc at line 1867.

https://cs.chromium.org/chromium/src/extensions/browser/api/web_request/web_request_api.cc?l=1867

It may have moved by the time you read this.

Please remove the histogram 'Extensions.DeclarativeWebRequestNetworkDelay'
from the source code. If it was very recently added, it may be worth adding
it to histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Cc: battre@chromium.org
Owner: karandeepb@chromium.org
Taking this over.

Comment 2 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics

Comment 3 by ricea@chromium.org, May 10 2018

Please remove the histogram.
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c675e1c9073a23eb81c4b65c597b4ed7ea391cd4

commit c675e1c9073a23eb81c4b65c597b4ed7ea391cd4
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Thu May 17 20:42:56 2018

Extensions: Remove unmapped Extensions.DeclarativeWebRequestNetworkDelay histogram.

This CL removes the unmapped Extensions.DeclarativeWebRequestNetworkDelay
histogram. It is used to evaluate the time taken to evaluate the
declarativeWebRequest rulesets for a network request. Since the
declarativeWebRequest API is currently only launched on Stable for webviews and
there is no current investigation into their performance, remove this histogram.

BUG= 642628 

Change-Id: Ifecdd59f483088e5bfb7fe615f39be6b5fb1801c
Reviewed-on: https://chromium-review.googlesource.com/1063023
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559665}
[modify] https://crrev.com/c675e1c9073a23eb81c4b65c597b4ed7ea391cd4/extensions/browser/api/web_request/web_request_api.cc

Status: Fixed (was: Assigned)

Sign in to add a comment