New issue
Advanced search Search tips

Issue 642627 link

Starred by 1 user
Status: Fixed
Owner:
benjhayden@chromium.org
Closed: Jun 2018
Cc:
a...@chromium.org
hashimoto@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Download.SavePageType is unmapped

Project Member Reported by ricea@chromium.org, Aug 31 2016 
The histogram 'Download.SavePageType' is present in Chromium source code but
does not appear in histograms.xml. This means that data is collected for the
histogram but nothing useful is done with it.

The histogram was defined in
chrome/browser/download/save_package_file_picker.cc at line 252.

https://cs.chromium.org/chromium/src/chrome/browser/download/save_package_file_picker.cc?l=252

It may have moved by the time you read this.

Please remove the histogram 'Download.SavePageType' from the source code. If
it was very recently added, it may be worth adding it to histograms.xml
instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

Comment 1 by hashimoto@chromium.org, Aug 31 2016

Owner: benjhayden@chromium.org
Status: Assigned (was: Available)
git blame says I'm responsible for the line, but what I did was just rewriting the logic.
Seems the said histogram was added in https://codereview.chromium.org/10069014 by benjhayden.

Comment 2 by ricea@chromium.org, Aug 31 2016 

Thanks for checking. I excluded 8 people from the Hotlist-UnmappedHistograms bugs as they have touched far too many lines of code and so would get spammed with bug notifications. benjhayden@chromium.org is on that list.

Comment 3 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics

Comment 4 by ricea@chromium.org, May 10 2018 

Please remove the histogram or reassign.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fdebead5b6eeef1079b7bcae6a460b41d03e14f

commit 7fdebead5b6eeef1079b7bcae6a460b41d03e14f
Author: Ben Hayden <benjhayden@chromium.org>
Date: Mon Jun 04 23:37:15 2018

Remove Download.SavePageType UMA.

Bug:  642627 
Change-Id: Ifbdf6871608937abd144d56704432fc433388e12
Reviewed-on: https://chromium-review.googlesource.com/1086091
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564293}
[modify] https://crrev.com/7fdebead5b6eeef1079b7bcae6a460b41d03e14f/chrome/browser/download/save_package_file_picker.cc

Comment 6 by benjhayden@chromium.org, Jun 5 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment