New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642626 link

Starred by 1 user
Status: Fixed
Owner:
asvitk...@chromium.org
Closed: Aug 2016
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histograms matching Memory.* are unmapped

Project Member Reported by ricea@chromium.org, Aug 31 2016 
The following histograms are present in Chromium source code but do not
appear in histograms.xml.

Memory.ExtensionProcessCount defined at
chrome/browser/metrics/metrics_memory_details.cc line 192
https://cs.chromium.org/chromium/src/chrome/browser/metrics/metrics_memory_details.cc?l=192

Memory.Swap.Zygote defined at
chrome/browser/metrics/metrics_memory_details.cc line 262
https://cs.chromium.org/chromium/src/chrome/browser/metrics/metrics_memory_details.cc?l=262

Memory.Zygote defined at chrome/browser/metrics/metrics_memory_details.cc
line 139
https://cs.chromium.org/chromium/src/chrome/browser/metrics/metrics_memory_details.cc?l=139

File and line information may be out-of-date by the time you read this.

Please remove these histograms from the source code. If they were very
recently added, it may be worth adding them to histograms.xml instead, but
probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histograms
anyway.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/792954ab4f88e8c4881a6f686aedb7de4d4bf1f6

commit 792954ab4f88e8c4881a6f686aedb7de4d4bf1f6
Author: asvitkine <asvitkine@chromium.org>
Date: Wed Aug 31 20:14:03 2016

Add undocumented Memory.* histograms to histograms.xml.

Makes them owned by the same people that own other Memory.*
histograms.

Also, adds a summary for a TBD histogram and adds units to
process count histograms.

BUG= 642626 

Review-Url: https://codereview.chromium.org/2300643003
Cr-Commit-Position: refs/heads/master@{#415736}

[modify] https://crrev.com/792954ab4f88e8c4881a6f686aedb7de4d4bf1f6/tools/metrics/histograms/histograms.xml

Comment 2 by asvitk...@chromium.org, Aug 31 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment