Quick view doesn't show image info for PNGs and SVGs |
|||||||||||||||
Issue descriptionVersion: ToT OS: Chrome OS What steps will reproduce the problem? (1) Select a PNG file in Files app (2) Press SPACE key (3) Observe metadata shown in right pane What is the expected output? Image Info like Resolution is displayed. What do you see instead? Only General Info is displayed. Please use labels and text to provide additional information.
,
Jan 11 2017
,
Jan 11 2017
Currently we don't show dimension if it isn't contained in metadata, but for supporting it for all images, HTMLImageElement's naturalHeight attribute will be useful. https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement
,
Jan 23 2017
,
Jan 23 2017
,
Sep 5 2017
Lifting this as a potential PE bug for M63.
,
Sep 6 2017
,
Sep 6 2017
,
Sep 8 2017
,
Sep 12 2017
Marianne, could you take a look?
,
Sep 25 2017
Let me investigate it a little. I guess it should involve messaging between webivew and Files app.
,
Sep 26 2017
Actually there's already PngParser. https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js?l=80 Maybe it's just not called from Quick View Marianne, could you take a look?
,
Sep 27 2017
Absolutely! weifangsun@, mcirimele@: What information do you want to see for SVGs? Dimensions don't really make sense for vector graphics IIUC.
,
Sep 27 2017
Hi mariannet@ Yes, agree that dimensions don't make sense. Size and modified time would be a good start!
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ada41c462c0dd7eb9762fc22f6e4b8b2f9fd54b0 commit ada41c462c0dd7eb9762fc22f6e4b8b2f9fd54b0 Author: mariannet <mariannet@google.com> Date: Tue Oct 03 08:15:02 2017 Display image metadata for more formats than just JPEG and ICO. There are parsers for more image formats than just JPEG and ICO, that never got called. By calling them, dimensions now get displayed for all image files that have a parser. Bug: 642607 Test: manually check the metadata displayed is correct Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie908ae1a499c6d164f4b04642461af8332e7b437 Reviewed-on: https://chromium-review.googlesource.com/688255 Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Keigo Oka <oka@chromium.org> Commit-Queue: Marianne Thieffry <mariannet@google.com> Cr-Commit-Position: refs/heads/master@{#505981} [modify] https://crrev.com/ada41c462c0dd7eb9762fc22f6e4b8b2f9fd54b0/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
,
Oct 3 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by satorux@chromium.org
, Jan 11 2017