New issue
Advanced search Search tips

Issue 642605 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

texelFetchOffset works wrongly on Intel Mac

Project Member Reported by jie.a.c...@intel.com, Aug 31 2016

Issue description

It's reproducible with sdk/tests/deqp/functional/gles3/shadertexturefunction/texelfetchoffset.html

ANGLE has a walkaround for Intel Win. It can be used also for Mac.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/7ef9aa7b968034bbf197b51bc37d80dffed56712

commit 7ef9aa7b968034bbf197b51bc37d80dffed56712
Author: jchen10 <jie.a.chen@intel.com>
Date: Wed Aug 31 07:39:38 2016

Enable texelFetchOffset re-writing for GLSL translator

Intel Mac has the same bug as Win. So the CL enables it in GLSL translator as
well.

BUG= chromium:642605 
TEST=deqp/functional/gles3/shadertexturefunction/texelfetchoffset.html

Change-Id: I30323ea3a6d4c07ff32e50bd7c574916b5b865f4
Reviewed-on: https://chromium-review.googlesource.com/378601
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/7ef9aa7b968034bbf197b51bc37d80dffed56712/src/compiler/translator/TranslatorGLSL.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a41f72543f178a392d9886548047f921ac1fc1d

commit 4a41f72543f178a392d9886548047f921ac1fc1d
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Thu Sep 01 02:50:58 2016

Roll ANGLE ad10a4a..a4e6f07

https://chromium.googlesource.com/angle/angle.git/+log/ad10a4a..a4e6f07

BUG= chromium:233383 , chromium:642227 , chromium:642605 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2296173003
Cr-Commit-Position: refs/heads/master@{#415863}

[modify] https://crrev.com/4a41f72543f178a392d9886548047f921ac1fc1d/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b685fdd155127fe973821416319cfcead1b10a8

commit 0b685fdd155127fe973821416319cfcead1b10a8
Author: jie.a.chen <jie.a.chen@intel.com>
Date: Fri Sep 02 02:41:04 2016

Add texelFetchOffset walkaround for Intel Mac

Rewrite from "texelFetchOffset(sampler, position, lod, offset)" to
"texelFetch(sampler, position+offset, lod)", as Intel Mac drivers
mistakenly consider the parameter "position" of nagative vaule as
invalid even if the sum of "position" and "offset" is in range.

BUG= 642605 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2300573002
Cr-Commit-Position: refs/heads/master@{#416172}

[modify] https://crrev.com/0b685fdd155127fe973821416319cfcead1b10a8/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/0b685fdd155127fe973821416319cfcead1b10a8/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/0b685fdd155127fe973821416319cfcead1b10a8/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/0b685fdd155127fe973821416319cfcead1b10a8/gpu/config/gpu_driver_bug_workaround_type.h

Status: Fixed (was: Assigned)

Sign in to add a comment