New issue
Advanced search Search tips

Issue 642604 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature

Blocking:
issue 512433



Sign in to add a comment

Retrieve port manufacturer and driver version in Windows 10 Web MIDI backend

Project Member Reported by shaochuan@chromium.org, Aug 31 2016

Issue description

According to https://msdn.microsoft.com/windows/uwp/devices-sensors/device-information-properties, we may retrieve both properties from Device DeviceInformation, but in our case both MidiInPort and MidiOutPort are DeviceInterface. We should look for ways to identify the underlying Device of the DeviceInterface in order to obtain both properties.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8e2dc9ac7f01df69d0b3dccb9945b63b5fa06b0

commit a8e2dc9ac7f01df69d0b3dccb9945b63b5fa06b0
Author: shaochuan <shaochuan@chromium.org>
Date: Tue Sep 06 08:42:12 2016

Retrieve driver information in WinRT WebMIDI backend

Now MidiManagerWinrt retrieves driver manufacturer and version of each MIDI
port through Setup API.

BUG= 512433 , 642604 
R=toyoshim@chromium.org

Review-Url: https://codereview.chromium.org/2309253002
Cr-Commit-Position: refs/heads/master@{#416607}

[modify] https://crrev.com/a8e2dc9ac7f01df69d0b3dccb9945b63b5fa06b0/media/midi/midi_manager_winrt.cc

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6dffa1061e486bde2448c01e314e244497def46

commit e6dffa1061e486bde2448c01e314e244497def46
Author: shaochuan <shaochuan@chromium.org>
Date: Fri Sep 09 08:24:14 2016

Replace Setup API with PnP Configuration Manager in MidiManagerWinrt

Now retrieving driver information with PnP Configuration Manager, which is much
faster than using Setup API.
With the new approach we are now able to fetch information from the actual
device driver, instead of the software interface on top which seems to be always
provided by Microsoft.

BUG= 512433 , 642604 
R=toyoshim@chromium.org

Review-Url: https://codereview.chromium.org/2318953002
Cr-Commit-Position: refs/heads/master@{#417536}

[modify] https://crrev.com/e6dffa1061e486bde2448c01e314e244497def46/media/midi/BUILD.gn
[modify] https://crrev.com/e6dffa1061e486bde2448c01e314e244497def46/media/midi/midi_manager_winrt.cc

Sign in to add a comment