New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642583 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit 29 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: automatic workspace mappings

Project Member Reported by lushnikov@chromium.org, Aug 31 2016

Issue description

It should be possible to setup workspace mappings automatically.

Design doc: https://docs.google.com/document/d/1InexzPzt8fxXPy2ioRgvfZNgB3cya0JOUeImqGUn-lQ/edit#


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81a8295b83078bbd76cafa9b0531e1a33abd7e7

commit f81a8295b83078bbd76cafa9b0531e1a33abd7e7
Author: lushnikov <lushnikov@chromium.org>
Date: Thu Sep 08 02:17:39 2016

DevTools: cleanup WI.CSSWorkspaceBindings

This patch:
- removes WI.CSSWorkspaceBindings.pushSourceMapping. There's no need to
  push any source mappings - rawLocationToUILocation can always query
  SASSSourceMapping first and then StylesSourceMapping.
- removes WI.CSSWorkspaceBindings.HeaderInfo. The class was inlined into
  WI.CSSWorkspaceBindings.TargetInfo.

BUG= 642583 
R=dgozman

Review-Url: https://codereview.chromium.org/2300523002
Cr-Commit-Position: refs/heads/master@{#417166}

[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/selector-line-deprecated.html
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/selector-line-sourcemap-header-deprecated.html
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-live-locations-leak.html
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81a8295b83078bbd76cafa9b0531e1a33abd7e7

commit f81a8295b83078bbd76cafa9b0531e1a33abd7e7
Author: lushnikov <lushnikov@chromium.org>
Date: Thu Sep 08 02:17:39 2016

DevTools: cleanup WI.CSSWorkspaceBindings

This patch:
- removes WI.CSSWorkspaceBindings.pushSourceMapping. There's no need to
  push any source mappings - rawLocationToUILocation can always query
  SASSSourceMapping first and then StylesSourceMapping.
- removes WI.CSSWorkspaceBindings.HeaderInfo. The class was inlined into
  WI.CSSWorkspaceBindings.TargetInfo.

BUG= 642583 
R=dgozman

Review-Url: https://codereview.chromium.org/2300523002
Cr-Commit-Position: refs/heads/master@{#417166}

[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/selector-line-deprecated.html
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/selector-line-sourcemap-header-deprecated.html
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-live-locations-leak.html
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
[modify] https://crrev.com/f81a8295b83078bbd76cafa9b0531e1a33abd7e7/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

Labels: -Pri-1 Pri-2
Cc: lushnikov@chromium.org
 Issue 655834  has been merged into this issue.
asdf.png
31.1 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d

commit ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Oct 25 18:34:01 2016

DevTools: [Persistence] implement automapping

This patch implements automapping algorithm, as described in
https://goo.gl/7o1CRr

TL;DR: automapping algorithm relies on file names and metadatas
to associate resources with filesystem files.

BUG= 642583 

Review-Url: https://codereview.chromium.org/2418813005
Cr-Commit-Position: refs/heads/master@{#427419}

[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-dynamic-uisourcecodes-expected.txt
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-dynamic-uisourcecodes.html
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-git-folders-expected.txt
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-git-folders.html
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sane-expected.txt
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sane.html
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sourcemap-expected.txt
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-sourcemap.html
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-test.js
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-rename-mapped-file-expected.txt
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-expected.txt
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs-expected.txt
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-network-uisourcecode-expected.txt
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/s.css
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/s.css.map
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/s.scss
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js
[add] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/front_end/settings/editFileSystemView.css
[modify] https://crrev.com/ab5d9e70e6f119e47b9fd0c6bac2ccc33d19b22d/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Status: Fixed (was: Assigned)

Sign in to add a comment