New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 642581 link

Starred by 1 user
Status: Fixed
Owner:
█ jaydasika@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
weiliangc@chromium.org
ajuma@chromium.org
█ jaydasika@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 594675
issue 642584
issue 703818



Sign in to add a comment

Cache clip calculations outside clip nodes

Project Member Reported by weiliangc@chromium.org, Aug 31 2016 
When calculating clip rect/visible rect, since using target information from effect tree, we cannot cache values on clip nodes.

Possible results to cache:
 - clip node's clip in certain target effect node space, for calculating clip in target space
 - clip node's combined clip in screen space (?) for calculating visible rects
    - combining clip in screen space will lead to inflation of clips when there is rotation. This is easier to implement the cache, though might not be the best way to do calculation.

Comment 1 by weiliangc@chromium.org, Aug 31 2016

Blockedon: 642584

Comment 2 by weiliangc@chromium.org, Aug 31 2016

Blocking: 642584

Comment 3 by weiliangc@chromium.org, Aug 31 2016

Blockedon: -642584

Comment 4 by jaydasika@chromium.org, Mar 21 2017

Blocking: 703818
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a6b144350b8c18f94c48143414031627572dd41

commit 3a6b144350b8c18f94c48143414031627572dd41
Author: jaydasika <jaydasika@chromium.org>
Date: Tue Mar 21 23:11:19 2017

cc : Clean up cc clip tree

* Cache the dynamically computed clip and visible rects and use them to calculate clip and visible rects.

* Stop creating clip nodes for render surfaces.

* Delete combined_clip_in_target_space, clip_in_target_space,
  target_effect_id, layer_clipping_uses_only_local_clip,
  layers_are_clipped, layers_are_clipped_when_surfaces_disabled,
  resets_clip from clip node

* Remove the verify_clip_rect_calculations path from tests.

BUG= 642578 ,  642584 ,  642581 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2655233006
Cr-Commit-Position: refs/heads/master@{#458597}

[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/BUILD.gn
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/output/bsp_tree_perftest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/fake_layer_tree_host.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/fake_layer_tree_host_impl.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/layer_test_common.cc
[delete] https://crrev.com/d528436cf0ab46778ccd56a439a250e41113fc46/cc/test/layer_tree_settings_for_testing.cc
[delete] https://crrev.com/d528436cf0ab46778ccd56a439a250e41113fc46/cc/test/layer_tree_settings_for_testing.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/layer_tree_test.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/test_layer_tree_host_base.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/clip_node.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/clip_node.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/draw_property_utils.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_common.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_common_perftest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/property_tree.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/property_tree.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/property_tree_builder.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d352343ea9f42bef775ee6d05e1e2832f02cd4a3

commit d352343ea9f42bef775ee6d05e1e2832f02cd4a3
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Wed Mar 22 01:54:05 2017

Auto-rebaseline for r458597

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/639493

https://chromium.googlesource.com/chromium/src/+/3a6b144350b8c

BUG= 642581 
TBR=jaydasika@chromium.org

Review-Url: https://codereview.chromium.org/2768433004 .
Cr-Commit-Position: refs/heads/master@{#458617}

[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.png
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/linux/compositing/direct-image-compositing-expected.png
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-expected.png
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/linux/compositing/lots-of-img-layers-with-opacity-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/direct-image-compositing-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/lots-of-img-layers-with-opacity-expected.png
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/mac/compositing/direct-image-compositing-expected.png
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-expected.png
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/mac/compositing/lots-of-img-layers-with-opacity-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/direct-image-compositing-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/lots-of-img-layers-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/lots-of-img-layers-with-opacity-expected.png
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/win/compositing/direct-image-compositing-expected.png
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/win/compositing/lots-of-img-layers-expected.png
[modify] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/win/compositing/lots-of-img-layers-with-opacity-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/direct-image-compositing-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/lots-of-img-layers-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/lots-of-img-layers-with-opacity-expected.png
[add] https://crrev.com/d352343ea9f42bef775ee6d05e1e2832f02cd4a3/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/compositing/overflow/nested-render-surfaces-with-rotation-expected.png

Comment 7 by jaydasika@chromium.org, Mar 22 2017

Owner: jaydasika@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment