New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642578 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 594675



Sign in to add a comment

Calculate and verify is_clipped using clip tree without cached target information

Project Member Reported by weiliangc@chromium.org, Aug 31 2016

Issue description

There is currently code calculating clip_rect. is_clipped could be compute using clip_rect and layer bounds: if layer bounds is bigger than clip_rect, layer is clipped. Same goes for Render Surface.
 
Components: Internals>Compositing
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a6b144350b8c18f94c48143414031627572dd41

commit 3a6b144350b8c18f94c48143414031627572dd41
Author: jaydasika <jaydasika@chromium.org>
Date: Tue Mar 21 23:11:19 2017

cc : Clean up cc clip tree

* Cache the dynamically computed clip and visible rects and use them to calculate clip and visible rects.

* Stop creating clip nodes for render surfaces.

* Delete combined_clip_in_target_space, clip_in_target_space,
  target_effect_id, layer_clipping_uses_only_local_clip,
  layers_are_clipped, layers_are_clipped_when_surfaces_disabled,
  resets_clip from clip node

* Remove the verify_clip_rect_calculations path from tests.

BUG= 642578 ,  642584 ,  642581 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2655233006
Cr-Commit-Position: refs/heads/master@{#458597}

[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/BUILD.gn
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/layer_impl_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/output/bsp_tree_perftest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/fake_layer_tree_host.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/fake_layer_tree_host_impl.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/fake_layer_tree_host_impl.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/layer_test_common.cc
[delete] https://crrev.com/d528436cf0ab46778ccd56a439a250e41113fc46/cc/test/layer_tree_settings_for_testing.cc
[delete] https://crrev.com/d528436cf0ab46778ccd56a439a250e41113fc46/cc/test/layer_tree_settings_for_testing.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/layer_tree_test.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/test/test_layer_tree_host_base.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/clip_node.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/clip_node.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/damage_tracker_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/draw_property_utils.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_common.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_common.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_common_perftest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/property_tree.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/property_tree.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/cc/trees/property_tree_builder.h
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
[modify] https://crrev.com/3a6b144350b8c18f94c48143414031627572dd41/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp

Owner: jaydasika@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment