New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642571 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Finch experiment to measure fullscreen SurfaceView

Project Member Reported by sande...@chromium.org, Aug 31 2016

Issue description

Now that we have a watch time metric, there is an obvious way to measure the effect of switching to SurfaceView playback for fullscreen video.

This experiment will disable that path for a portion of users, and measure the effect on watch time. We will also want to compare crash rates and PipelineStatus counts.
 
For future reference, the watch time metric is implemented in  issue 633743 .
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99fce27763b037227011e357502b1c700477d153

commit 99fce27763b037227011e357502b1c700477d153
Author: sandersd <sandersd@chromium.org>
Date: Thu Sep 01 00:59:00 2016

Add testing config for OverlayFullscreenVideo.

BUG= 642571 

Review-Url: https://codereview.chromium.org/2291413002
Cr-Commit-Position: refs/heads/master@{#415825}

[modify] https://crrev.com/99fce27763b037227011e357502b1c700477d153/testing/variations/fieldtrial_testing_config_android.json

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e36c9cd407f42368f7d2f5df5806a33303187b8

commit 4e36c9cd407f42368f7d2f5df5806a33303187b8
Author: sandersd <sandersd@chromium.org>
Date: Fri Sep 02 23:51:12 2016

Revert of Add testing config for OverlayFullscreenVideo. (patchset #1 id:1 of https://codereview.chromium.org/2291413002/ )

Reason for revert:
Turns out we shouldn't do this for optimization experiments, since we don't actually want this enabled for all dev builds.

Original issue's description:
> Add testing config for OverlayFullscreenVideo.
>
> BUG= 642571 
>
> Committed: https://crrev.com/99fce27763b037227011e357502b1c700477d153
> Cr-Commit-Position: refs/heads/master@{#415825}

TBR=asvitkine@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 642571 

Review-Url: https://codereview.chromium.org/2306233002
Cr-Commit-Position: refs/heads/master@{#416397}

[modify] https://crrev.com/4e36c9cd407f42368f7d2f5df5806a33303187b8/testing/variations/fieldtrial_testing_config_android.json

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e36c9cd407f42368f7d2f5df5806a33303187b8

commit 4e36c9cd407f42368f7d2f5df5806a33303187b8
Author: sandersd <sandersd@chromium.org>
Date: Fri Sep 02 23:51:12 2016

Revert of Add testing config for OverlayFullscreenVideo. (patchset #1 id:1 of https://codereview.chromium.org/2291413002/ )

Reason for revert:
Turns out we shouldn't do this for optimization experiments, since we don't actually want this enabled for all dev builds.

Original issue's description:
> Add testing config for OverlayFullscreenVideo.
>
> BUG= 642571 
>
> Committed: https://crrev.com/99fce27763b037227011e357502b1c700477d153
> Cr-Commit-Position: refs/heads/master@{#415825}

TBR=asvitkine@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 642571 

Review-Url: https://codereview.chromium.org/2306233002
Cr-Commit-Position: refs/heads/master@{#416397}

[modify] https://crrev.com/4e36c9cd407f42368f7d2f5df5806a33303187b8/testing/variations/fieldtrial_testing_config_android.json

Status: Fixed (was: Started)
(Closing in favor of 644371, which tracks the launch of this change.)

Sign in to add a comment