New issue
Advanced search Search tips

Issue 642566 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add Precache.Events value for cancelling due to control group

Project Member Reported by twif...@chromium.org, Aug 31 2016

Issue description

Unfortunately, the Java code is much less reliable than the C++ code at reporting UMAs, so filtering by FailureReasons==0 eliminates all users. We need a metric that we can filter by in both control and experiment, so we can reduce selection bias.

Suggestion: Make PrecacheManager::OnGetUnfinishedWorkDone report an UMA (e.g. a new Precache.Events value) if IsInControlGroup(), just before OnDone(). This would be comparable, then, to Precache.Fetch.PercentCompleted on the experiment side.
 
Status: WontFix (was: Untriaged)
Looks like this is actually fine. As of http://crrev.com/52ae19d6, Precache.Events reports PRECACHE_SESSION_COMPLETE (from Java) about as often as Precache.Fetch.PercentCompleted reports (from C++).

Sign in to add a comment