New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642564 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocking:
issue 641632



Sign in to add a comment

HBD: Update Omnibox Site Settings Permissions Dropdown for HBD

Project Member Reported by tommycli@chromium.org, Aug 30 2016

Issue description

Need UI feedback:

Need a HBD equivalent strings for the following strings:

"Detect important content by default"
"Detect important content by you"
"Always detect important content on this site"

I'm suggesting:

"Ask first by default"
"Ask first by you"
"Always ask first on this site"

Also - do you want me to update Plugins => Flash on this UI surface?

Also - should we update all those puzzle piece icons to the Flash icon if we're renaming?
 
Screenshot from 2016-08-30 16:50:25.png
95.5 KB View Download
My new suggestion is to just reused the ASK strings for HBD:

"Ask by default"
"Ask by you"
"Always ask on this site"

The way the code is set up, making custom strings for just Plugins would be terribly inconvenient for engineering.
Screenshot from 2016-08-30 17:14:10.png
92.4 KB View Download

Comment 2 by rolfe@chromium.org, Aug 31 2016

What are the current drop-down strings for Plugins? (Can't check as blocked by policy. Can you pull them from the build?)
rolfe@: The current drop down strings for Plugins are in c#1. You can see the screenshot.

The screenshot in c#2 is my suggestion of just using the ASK strings when HBD is active.

And we should probably rename Plugins => Flash too, but I wanted to ask you on that first.

Comment 4 by rolfe@chromium.org, Aug 31 2016

1) ericde@ confirmed in a doc somewhere that the puzzle piece is fine.

2) Renaming "Plugins" to "Flash" works for me.

3) Page info: Oh I see we got ourselves in a bit of a muddle. In supporting the old-style in a radial format, we now have both an Ask and Allow as possible options. I think you'd have:

NOT SELECTED
Ask by default

SELECTED
Use global default (ask)
Allow on this site
Block on this site

Because the radials are essentially set up like other ask-first permissions. Once you ask, the preference changes to "allow." And if the user set it to always allow, the site would have "allow on this site" selected too. Would that work?
Hi rolfe@:

What is a "radial format"? I also didn't really understand the last sentence.

Are you proposing removing the ability to add a DETECT exception from the context menu?

When I look at every other type of content setting in that UI, I only see 

Use global default (allow or ask)
Allow on this site
Block on this site

And you want to do the same thing for Plugins right?

That means removing both the "Detect..." option and the "Ask..." option in the middle? For both HBD on and off?

Comment 6 by rolfe@chromium.org, Aug 31 2016

Sorry "radial" is the old-fashioned terrm for "radio," the button format per the pre-MD layout you propose here:
https://bugs.chromium.org/p/chromium/issues/detail?id=622922#c66

You'd keep "detect..." in the drop down when the flag is off. But when it's on (and set to Ask) it becomes like any other ask setting. Does that sound right to you?
SGTM, thanks for the clarification!
Screenshot of new menu with HBD on attached per our latest understanding.
Screenshot from 2016-08-31 17:50:52.png
90.2 KB View Download

Comment 9 by rolfe@chromium.org, Sep 1 2016

Looks good to me!
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/691e0c7d46341465de7a605b5f2aee941ccfedc0

commit 691e0c7d46341465de7a605b5f2aee941ccfedc0
Author: tommycli <tommycli@chromium.org>
Date: Thu Sep 15 17:21:08 2016

[HBD] Update Plugins type in Website Settings Permissions UI

Renames Plugins => Flash since Flash is the last real plugin as of
M55.

Also, when the kPreferHtmlOverPlugins feature flag is on, remove
the Detect option and make it look the same as any other
ASK-default content type.

BUG= 642564 

Review-Url: https://codereview.chromium.org/2291323003
Cr-Commit-Position: refs/heads/master@{#418894}

[modify] https://crrev.com/691e0c7d46341465de7a605b5f2aee941ccfedc0/chrome/app/generated_resources.grd
[modify] https://crrev.com/691e0c7d46341465de7a605b5f2aee941ccfedc0/chrome/browser/ui/website_settings/permission_menu_model.cc
[modify] https://crrev.com/691e0c7d46341465de7a605b5f2aee941ccfedc0/chrome/browser/ui/website_settings/website_settings_ui.cc

Status: Fixed (was: Untriaged)
Blocking: 641632

Sign in to add a comment