Issue 642560 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ pho...@chromium.org Last visit > 30 days ago
Closed:	Sep 2016
Cc:	█ jrbarnette@chromium.org
Components:	Infra>Client>ChromeOS
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Clean up run_autoserv SystemExit crap

Project Member Reported by pho...@chromium.org, Aug 30 2016

Issue description

autoserv's "run_autoserv" process calls sys.exit(exit_code) only to immediately have the SystemExit caught (and logged) by the parent record_autoserv function's stack frame.  In that case, we both log the exception in run_autoserv (which is reasonable) and log the SystemExit exception in record_autoserv, which just adds noise.

We can clean up this logic by not bothering to catch exceptions in run_autoserv, since they will be caught and logged by record_autoserv anyway.

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/20cc72ac289b10e362e2865f4b662425f6ea1a6d

commit 20cc72ac289b10e362e2865f4b662425f6ea1a6d
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Aug 30 23:57:05 2016

[autotest] Setup ts_mon in autoserv.

Added code to set up ts_mon flushing process before running autoserv
jobs. Also, cleaned up run_autoserv's usage of sys.exit.

TEST=None
BUG=chromium:642402
BUG= chromium:642560 

Change-Id: Ifbb9bd17871d1215d085cc82f6bd43cfc75b7f49
Reviewed-on: https://chromium-review.googlesource.com/378596
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/20cc72ac289b10e362e2865f4b662425f6ea1a6d/server/site_utils.py
[modify] https://crrev.com/20cc72ac289b10e362e2865f4b662425f6ea1a6d/server/autoserv