New issue
Advanced search Search tips

Issue 642551 link

Starred by 2 users
Status: Verified
Owner:
afakhry@chromium.org
Closed: Sep 2016
Cc:
abodenha@chromium.org
osh...@chromium.org
omrilio@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

TouchView testing flag is broken

Project Member Reported by tbuck...@chromium.org, Aug 30 2016 
Chrome Version: 54.0.2837.0
OS Version: 8737.1.0

What steps will reproduce the problem?
1. On Samus, enable chrome://flags#ash-enable-touch-view-testing
2. Restart
3. Hit Ctrl+Alt+Shift+8 to toggle TouchView

What is the expected result?
Toggle in/out of TouchView

What happens instead of that?
Nothing happens

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 8737.1.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2837.0 Safari/537.36

Comment 1 by afakhry@chromium.org, Sep 15 2016

Cc: osh...@chromium.org
Owner: afakhry@chromium.org
Status: Started (was: Assigned)
Will be fixed in the same CL I'm working on right now.

Comment 2 by afakhry@chromium.org, Sep 15 2016 

Also, apparently that shortcut was changed to be Ctrl+Alt+Shift+T.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd09f64d921e02333652d2fae387b8b406201cf8

commit cd09f64d921e02333652d2fae387b8b406201cf8
Author: afakhry <afakhry@chromium.org>
Date: Fri Sep 16 22:26:56 2016

Separate debugging and developer accelerators

Hide developer accelerators behind --ash-developer-shortcuts command line
switch.

BUG= 642945 , 642551 

Review-Url: https://codereview.chromium.org/2323863002
Cr-Commit-Position: refs/heads/master@{#419301}

[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/accelerator_table.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/accelerator_table.h
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/debug_commands.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/accelerators/debug_commands.h
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/ash_switches.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/common/ash_switches.h
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/mus/accelerators/accelerator_controller_delegate_mus.cc
[modify] https://crrev.com/cd09f64d921e02333652d2fae387b8b406201cf8/ash/mus/accelerators/accelerator_controller_unittest.cc

Comment 4 by afakhry@chromium.org, Sep 20 2016

Status: Fixed (was: Started)
This is fixed now. Enable the #ash-debug-shortcuts in chrome://flags and use Ctrl+Alt+Shift+T.

Comment 5 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 6 by sdantul...@chromium.org, Oct 20 2016

Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20 as per repro steps in comment #0 and comment #4
►

Sign in to add a comment