New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642550 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
HSTS-Preload


Sign in to add a comment

Preload mail.google.com for expect-CT

Project Member Reported by lgar...@chromium.org, Aug 30 2016

Issue description

Creating a bug to track this. Based on an email discussion, it is highly desirable to land and merge this to Chrome 54 in order to get useful data.

Toss back to me if I go on vacation, Emily. :-)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/411a3286e3d5a064cca8cabf52f54d42c0206f93

commit 411a3286e3d5a064cca8cabf52f54d42c0206f93
Author: Emily Stark <estark@google.com>
Date: Wed Aug 31 00:22:52 2016

Preload Expect-CT for mail.google.com

In addition, this picks up a change to the Dropbox Expect-Staple
report URL. Looks like this change was made in the json file in
https://codereview.chromium.org/2129543003/ but not in the generated .h.

BUG= 642550 
R=lgarron@chromium.org

Review URL: https://codereview.chromium.org/2293283002 .

Cr-Commit-Position: refs/heads/master@{#415512}

[modify] https://crrev.com/411a3286e3d5a064cca8cabf52f54d42c0206f93/net/http/transport_security_state_static.h
[modify] https://crrev.com/411a3286e3d5a064cca8cabf52f54d42c0206f93/net/http/transport_security_state_static.json

Comment 2 by est...@chromium.org, Aug 31 2016

Labels: M-55 Merge-Request-54
Status: Fixed (was: Assigned)
Requesting a merge to M54. This commit doesn't affect any Chrome functionality but just adds a site to a hard-coded list.

Comment 3 by est...@chromium.org, Aug 31 2016

Cc: est...@chromium.org
Owner: lgar...@chromium.org
Reassigning to lgarron to follow up on the merge; thanks, Lucas.

Comment 4 by dimu@chromium.org, Aug 31 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceb929274a8c158af77e64846c1534f9d501775b

commit ceb929274a8c158af77e64846c1534f9d501775b
Author: Emily Stark <estark@google.com>
Date: Wed Aug 31 23:41:02 2016

Preload Expect-CT for mail.google.com

In addition, this picks up a change to the Dropbox Expect-Staple
report URL. Looks like this change was made in the json file in
https://codereview.chromium.org/2129543003/ but not in the generated .h.

BUG= 642550 
R=lgarron@chromium.org

Review URL: https://codereview.chromium.org/2293283002 .

Cr-Commit-Position: refs/heads/master@{#415512}
(cherry picked from commit 411a3286e3d5a064cca8cabf52f54d42c0206f93)

Review URL: https://codereview.chromium.org/2303543002 .

Cr-Commit-Position: refs/branch-heads/2840@{#90}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ceb929274a8c158af77e64846c1534f9d501775b/net/http/transport_security_state_static.h
[modify] https://crrev.com/ceb929274a8c158af77e64846c1534f9d501775b/net/http/transport_security_state_static.json

Cc: nyerramilli@chromium.org
Labels: Needs-Feedback
Could you please help us with the steps to verify the issue from TE end.

Comment 7 by eranm@chromium.org, Sep 1 2016

Estark@ will confirm, iiuc there are histogram numbers you could watch.

Note the necessary header is not yet served by mail.google.com.
Components: Internals>Network>DomainSecurityPolicy
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceb929274a8c158af77e64846c1534f9d501775b

commit ceb929274a8c158af77e64846c1534f9d501775b
Author: Emily Stark <estark@google.com>
Date: Wed Aug 31 23:41:02 2016

Preload Expect-CT for mail.google.com

In addition, this picks up a change to the Dropbox Expect-Staple
report URL. Looks like this change was made in the json file in
https://codereview.chromium.org/2129543003/ but not in the generated .h.

BUG= 642550 
R=lgarron@chromium.org

Review URL: https://codereview.chromium.org/2293283002 .

Cr-Commit-Position: refs/heads/master@{#415512}
(cherry picked from commit 411a3286e3d5a064cca8cabf52f54d42c0206f93)

Review URL: https://codereview.chromium.org/2303543002 .

Cr-Commit-Position: refs/branch-heads/2840@{#90}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ceb929274a8c158af77e64846c1534f9d501775b/net/http/transport_security_state_static.h
[modify] https://crrev.com/ceb929274a8c158af77e64846c1534f9d501775b/net/http/transport_security_state_static.json

Sign in to add a comment