AFAIK: we agreed that mus doesn't need to support CrOS/X11 on devices. I'll figure out how MUS should do this. My understanding from marcheu@ is that for ozone drm devices, this is done externally to Chrome.

The code you are looking at is for X11 only, and as you say we don't care about it for Chrome OS.

For some reason, the splash screen copy is implemented differently for ozone drm than for X11 (it is implemented directly inside of ozone).

See src/ui/ozone/platform/drm/gpu/drm_console_buffer.cc which does get the existing framebuffer (from the splash screen) and copies it into a skia surface. Also see screen_manager.cc which calls into this from FillModesetBuffer().

sky@: perhaps you could find someone else to validate that this bug exists and/or has been fixed for mushrome?

With the switch to ozone this code is effectively dead and can be removed.

I should delete the fade_boot_splash_screen USE flag and associated code as well.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8995b2087a64fbb2d987b6d03d5bd03b88f237b3

commit 8995b2087a64fbb2d987b6d03d5bd03b88f237b3
Author: Daniel Erat <derat@chromium.org>
Date: Wed Aug 23 07:04:08 2017

login: Remove login-animation-related USE flags.

Remove code that checks for the old, unused
disable_login_animations and fade_boot_splash_screen USE
flags.

BUG= chromium:642540 
TEST=none

Change-Id: I6c547b8d362dc106d26aa06a2e8d3c7c559f714b
Reviewed-on: https://chromium-review.googlesource.com/627667
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8995b2087a64fbb2d987b6d03d5bd03b88f237b3/login_manager/chrome_setup.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8e4823774f1f7a73e6b92165bbf98f8bf8f2e566

commit 8e4823774f1f7a73e6b92165bbf98f8bf8f2e566
Author: Daniel Erat <derat@chromium.org>
Date: Wed Aug 23 09:02:39 2017

libchromeos-use-flags: Remove obsolete boot animation flags.

Remove the disable_login_animations and
fade_boot_splash_screen USE flags, which correspond to
dead/removed code in Chrome.

BUG= chromium:642540 
TEST=none

Change-Id: Ib54680ac22a9266043a45d35751181f2bee91b6d
Reviewed-on: https://chromium-review.googlesource.com/627666
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/8e4823774f1f7a73e6b92165bbf98f8bf8f2e566/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r36.ebuild
[modify] https://crrev.com/8e4823774f1f7a73e6b92165bbf98f8bf8f2e566/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dadd7ed0e38c36d1905442bbe3f6dbcc0a1c20d

commit 2dadd7ed0e38c36d1905442bbe3f6dbcc0a1c20d
Author: Scott Violet <sky@chromium.org>
Date: Wed Aug 23 15:14:07 2017

chromeos: removes BootSplashScreen

With the switch to ozone it's no longer used.

BUG= 642540 
TEST=none

Change-Id: Icc36593304b0055912626d035ba4842f1c11f67b
Reviewed-on: https://chromium-review.googlesource.com/627060
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496688}
[modify] https://crrev.com/2dadd7ed0e38c36d1905442bbe3f6dbcc0a1c20d/ash/BUILD.gn
[modify] https://crrev.com/2dadd7ed0e38c36d1905442bbe3f6dbcc0a1c20d/ash/ash_switches.cc
[modify] https://crrev.com/2dadd7ed0e38c36d1905442bbe3f6dbcc0a1c20d/ash/ash_switches.h
[modify] https://crrev.com/2dadd7ed0e38c36d1905442bbe3f6dbcc0a1c20d/ash/root_window_controller.cc
[modify] https://crrev.com/2dadd7ed0e38c36d1905442bbe3f6dbcc0a1c20d/ash/root_window_controller.h
[modify] https://crrev.com/2dadd7ed0e38c36d1905442bbe3f6dbcc0a1c20d/ash/wallpaper/wallpaper_widget_controller.cc
[delete] https://crrev.com/2bf5d7200067f017046f6e3c0bd327d2bcb39df5/ash/wm/boot_splash_screen_chromeos.cc
[delete] https://crrev.com/2bf5d7200067f017046f6e3c0bd327d2bcb39df5/ash/wm/boot_splash_screen_chromeos.h

Dan, is there anything else to remove in ChromeOS repos? Should I marked this fixed?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/e2db758f74ecb9db892b9385a73927db7451ed05

commit e2db758f74ecb9db892b9385a73927db7451ed05
Author: Daniel Erat <derat@chromium.org>
Date: Wed Aug 23 21:18:05 2017

overlays: Remove obsolete login animation USE flags.

Remove the disable_login_animations USE flag from x86-alex,
x86-mario, and x86-zgb, and fade_boot_splash_screen from
lumpy. These correspond to dead/removed code in Chrome.

BUG= chromium:642540 
TEST=none

Change-Id: Ida17c91c867daec174a253aad9199f5018b69a1c
Reviewed-on: https://chromium-review.googlesource.com/627665
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e2db758f74ecb9db892b9385a73927db7451ed05/overlay-lumpy/profiles/base/make.defaults
[modify] https://crrev.com/e2db758f74ecb9db892b9385a73927db7451ed05/overlay-x86-zgb/profiles/base/make.defaults
[modify] https://crrev.com/e2db758f74ecb9db892b9385a73927db7451ed05/overlay-x86-alex/profiles/base/make.defaults
[modify] https://crrev.com/e2db758f74ecb9db892b9385a73927db7451ed05/overlay-x86-mario/profiles/base/make.defaults

I think that should be it -- thanks!

Thank you for the help and cleanup in the ChromeOS repos.