Delete roll-dep-svn |
|||||||
Issue descriptionThis script is still used by the v8 autoroller. It shouldn't be, the git autoroller (roll-dep) provides a much cleaner interface, uploads CLs for you, and enforces a common format of autoroll commit messages. Also, the scripts name has "svn" in it, so really, it should go away :) https://cs.chromium.org/search/?q=roll-dep-svn&sq=package:chromium&type=cs
,
Aug 31 2016
Yeah, if you switched tools it would greatly simplify the auto_roll.py code, but at the cost of your special commit messages. That behavior could be built in to the git version of roll-dep, or abandoned. I'd call this P-1 because it is more important than the blocked bug (has to be done first), and because it is also an issue of reducing code duplication and dead code. Also, that blocked bug is virtually P-1 anyway, or we're treating it like it is our highest non-interrupt priority right now at least.
,
Dec 22 2016
I'm on a roll ripping SVN out of depot_tools today, so here's a CL that rips all of the SVN code out of roll-dep-svn: https://chromium-review.googlesource.com/c/422583/ It feels ridiculous, but it's the easiest way to get rid of SVN code without breaking v8, webrtc, and angle: https://cs.chromium.org/chromium/src/v8/tools/release/auto_roll.py?q=roll-dep-svn&sq=package:chromium&l=143&dr=C https://cs.chromium.org/chromium/src/tools/roll_angle.py?q=roll_dep_svn&sq=package:chromium&l=344&dr=C https://cs.chromium.org/chromium/src/tools/roll_webrtc.py?q=roll_dep_svn&sq=package:chromium&l=342&dr=C https://cs.chromium.org/chromium/src/tools/roll_webgl_conformance.py?q=roll_dep_svn&sq=package:chromium&l=321&dr=C If the above CL lands, then I'll re-assign back to machenbach@ to figure out how to unify roll-deps and roll-dep-svn, and remove the blocking relation since the svn code will be gone.
,
Apr 13 2017
Unassigning issues from myself that aren't related to the PolyGerrit migration. I won't have cycles for these in the immediate future so marking as Available.
,
Apr 16 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
@Edward, you have probably the best overview if someone is still depending on this after there's gclient setdep...
,
Jan 16
,
Jan 17
V8 does not depend on this anymore. But there's this one script here: https://cs.chromium.org/chromium/src/tools/roll_webgl_conformance.py?type=cs&q=roll_dep_svn&sq=package:chromium&g=0&l=49 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by machenb...@chromium.org
, Aug 31 2016Labels: -Type-Bug Type-Feature