New issue
Advanced search Search tips

Issue 642517 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add browser test for Expect-CT reporting

Project Member Reported by est...@chromium.org, Aug 30 2016

Issue description

In a discussion with Finch folks, it came up that it would be good to have browser test coverage of Expect-CT reporting, especially because the code rarely gets exercised in the wild (at least for now).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f51e5d491800e1a112f009266589625b1f6a4ab6

commit f51e5d491800e1a112f009266589625b1f6a4ab6
Author: Emily Stark <estark@google.com>
Date: Wed Jul 12 23:48:50 2017

Add browser test and testing config for dynamic Expect-CT reporting

This CL adds a browser test to check that the ChromeExpectCTReporter is properly
created and set up to receive reports, particularly for dynamic Expect-CT
violations. It also enables the dynamic Expect-CT feature on the waterfall.

BUG=679012, 642517 

Change-Id: I3ea01207ea5852b9bd0bbb1d90799ee4555c854e
Reviewed-on: https://chromium-review.googlesource.com/566572
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486158}
[add] https://crrev.com/f51e5d491800e1a112f009266589625b1f6a4ab6/chrome/browser/ssl/chrome_expect_ct_reporter_browser_tests.cc
[modify] https://crrev.com/f51e5d491800e1a112f009266589625b1f6a4ab6/chrome/test/BUILD.gn
[modify] https://crrev.com/f51e5d491800e1a112f009266589625b1f6a4ab6/testing/variations/fieldtrial_testing_config.json

Comment 2 by est...@chromium.org, Jul 13 2017

Labels: M-61
Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca8fd661af507b4c2980ae6fd961b8346b3dfa3

commit 3ca8fd661af507b4c2980ae6fd961b8346b3dfa3
Author: Emily Stark <estark@chromium.org>
Date: Thu Jul 13 17:00:34 2017

Revert "Add browser test and testing config for dynamic Expect-CT reporting"

This reverts commit f51e5d491800e1a112f009266589625b1f6a4ab6.

Reason for revert: This test fails on official builds because the field trial testing config doesn't apply. I will explicitly enable the Finch feature in the test and reland.

Original change's description:
> Add browser test and testing config for dynamic Expect-CT reporting
> 
> This CL adds a browser test to check that the ChromeExpectCTReporter is properly
> created and set up to receive reports, particularly for dynamic Expect-CT
> violations. It also enables the dynamic Expect-CT feature on the waterfall.
> 
> BUG=679012, 642517 
> 
> Change-Id: I3ea01207ea5852b9bd0bbb1d90799ee4555c854e
> Reviewed-on: https://chromium-review.googlesource.com/566572
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
> Commit-Queue: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486158}

TBR=jwd@chromium.org,meacer@chromium.org,estark@chromium.org

Change-Id: I60d13cfa015707d535e0afb86cf10d74ecb35b79
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 679012,  642517 
Reviewed-on: https://chromium-review.googlesource.com/570383
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486415}
[delete] https://crrev.com/450a8feea254f54e61be2bf5529e26027c656d6b/chrome/browser/ssl/chrome_expect_ct_reporter_browser_tests.cc
[modify] https://crrev.com/3ca8fd661af507b4c2980ae6fd961b8346b3dfa3/chrome/test/BUILD.gn
[modify] https://crrev.com/3ca8fd661af507b4c2980ae6fd961b8346b3dfa3/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886f7089046c0ab1bf44c2f9a02e18b0dc0ad7d6

commit 886f7089046c0ab1bf44c2f9a02e18b0dc0ad7d6
Author: Emily Stark <estark@google.com>
Date: Fri Jul 14 02:18:58 2017

Reland "Add browser test and testing config for dynamic Expect-CT reporting"

This is a reland of f51e5d491800e1a112f009266589625b1f6a4ab6
Original change's description:
> Add browser test and testing config for dynamic Expect-CT reporting
> 
> This CL adds a browser test to check that the ChromeExpectCTReporter is properly
> created and set up to receive reports, particularly for dynamic Expect-CT
> violations. It also enables the dynamic Expect-CT feature on the waterfall.
> 
> BUG=679012, 642517 
> 
> Change-Id: I3ea01207ea5852b9bd0bbb1d90799ee4555c854e
> Reviewed-on: https://chromium-review.googlesource.com/566572
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
> Commit-Queue: Emily Stark <estark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486158}

TBR=jwd@chromium.org

Bug: 679012,  642517 
Change-Id: If0a05ea0823f0427f04c455206ab8a7f7020fc89
Reviewed-on: https://chromium-review.googlesource.com/570561
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486637}
[add] https://crrev.com/886f7089046c0ab1bf44c2f9a02e18b0dc0ad7d6/chrome/browser/ssl/chrome_expect_ct_reporter_browser_tests.cc
[modify] https://crrev.com/886f7089046c0ab1bf44c2f9a02e18b0dc0ad7d6/chrome/test/BUILD.gn
[modify] https://crrev.com/886f7089046c0ab1bf44c2f9a02e18b0dc0ad7d6/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment