New issue
Advanced search Search tips

Issue 642498 link

Starred by 2 users
Status: Fixed
Owner:
estevenson@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Compile steps should only use a wrapper if resource whitelisting is enabled

Project Member Reported by estevenson@chromium.org, Aug 30 2016 
Unused resource whitelisting was added to official builds on android in https://codereview.chromium.org/2272713004, but the compile command wrapper (build/toolchain/gcc_compile_wrapper.py) is used even when resource whitelisting isn't enabled.

It's inefficient to use this additional python process and it makes debugging failures harder.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b7fbab033063d07967e8fd9d084a53eb5d05edc

commit 3b7fbab033063d07967e8fd9d084a53eb5d05edc
Author: estevenson <estevenson@chromium.org>
Date: Wed Aug 31 13:57:31 2016

Only use gcc_compile_wrapper when resource whitelisting is enabled.

Using gcc_compile_wrapper.py unconditionally is inefficient and makes
debugging more difficult. This is problematic since resource
whitelisting occurs relatively infrequently.

BUG= 642498 

Review-Url: https://codereview.chromium.org/2296033002
Cr-Commit-Position: refs/heads/master@{#415624}

[modify] https://crrev.com/3b7fbab033063d07967e8fd9d084a53eb5d05edc/build/toolchain/gcc_toolchain.gni

Comment 2 by estevenson@chromium.org, Aug 31 2016

Status: Fixed (was: Started)
►

Sign in to add a comment