New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642484 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue gerrit:4452
issue gerrit:5003

Blocking:
issue 626103
issue 672378
issue 685318
issue 685321



Sign in to add a comment

Gerrit Plugin: commit position footer generation

Project Member Reported by tandrii@chromium.org, Aug 30 2016

Issue description

See go/GNumGP

Integrate with Rebase Always submit strategy of Gerrit ( issue gerrit:4452 )
to alter footers on submission to comply with go/gnumbd design.
 
Do we have a bug in Gerrit yet to support this kind of extension point?
No. Now that i'm gerrit member i can file one.
Labels: Milestone-Fishfood Proj-Gerrit-Migration
Blockedon: gerrit:5003

Comment 6 Deleted

Comment 7 Deleted

Blocking: 672378
Update:

while generation works, the code is called *after* currently hooked validation code, which means that if validator is enabled, the generation code is never called.
hence, the solution is to create new validation hook which is called precisely after new commit is generated but before the destination branch ref is updated to point to it.

Very WIP https://gerrit-review.googlesource.com/c/93650/ with detailed reasoning. It has to be reworked (see Dave comments on it).
new extension point of Gerrit landed: https://gerrit-review.googlesource.com/c/94436/

4 Cls to make use of it are being landed (2/4 landed at this time)
https://chromium-review.googlesource.com/c/430826/5
https://chromium-review.googlesource.com/c/430904/3
https://chromium-review.googlesource.com/c/430932/3
https://chromium-review.googlesource.com/c/430909/1


What's next?
land them + deploy. And then enable Generator on refs/heads/master and refs/branch-heads/* in chromium repo :)
I think everything has landed as I intended. Waiting for this to be deployed.
It has been deployed. Tested and it works. Tried branching including that those outside of refs/heads/. Example: https://chromium.googlesource.com/playground/gerrit-cq/normal/+/refs/gitnum-heads/branch2
Cc: aga...@chromium.org andyb...@chromium.org
Status: Verified (was: Started)
Enabled generator for v8/v8: https://chromium.googlesource.com/v8/v8/+/81d10877c20705062483930d0ac09f7b0fd27c6a%5E%21

Enabled generator for chromium/src: 
https://chromium.googlesource.com/chromium/src/+/03cdeaa4994ae3bee6c53df237d5238608596f51%5E%21/

Enabled generator for external/webrtc: 
https://chromium.googlesource.com/external/webrtc/+/e1514e3d17e4875f498765e8ce8b6a1fcbcf7e0e%5E%21/#F0

From Git-Numberer PoV, these repos are ready for dogfood.
giphy.gif
89.7 KB View Download
Blocking: 685318
Blocking: 685321

Sign in to add a comment