TaskManagerBrowserTest.DevToolsNewUndockedWindow and AppBackgroundPageApiTest.NoJsBackgroundPage frequently crashing on Win 7 Tests Debug. |
|||||
Issue descriptionSee failures here: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20(dbg)(1) It seems to be somewhat flaky (we occasionally have green runs) but fails most of the time (about 4 in 5 runs fail). The failures in both seem to be the following: @@@STEP_LOG_LINE@AppBackgroundPageApiTest.NoJsBackgroundPage@[3348:304:0830/111813:FATAL:shared_sampler_win.cc(359)] Check failed: callbacks_map_.find(process_id) != callbacks_map_.end().@@@ The first failure seems to be https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52182 but given the tests intermittently pass the bad CL may be before that blame list.
,
Aug 30 2016
This code was introduced earlier but the change mentioned in comment #1 made it used by Task Manager's Memory column which I guess makes it callable by more tests. I think this is triggered by TaskManager occasionally calling this code with zero process_id. I have a check for zero process_id later in that code. Perhaps the DCHECK should be moved a couple of lines further down that code to avoid being triggered by a zero process_id. DCHECK(callbacks_map_.find(process_id) != callbacks_map_.end()); I'll file a separate bug for zero process_id.
,
Aug 30 2016
,
Aug 31 2016
More logs to make sure this does not get lost: Failed tests: TaskManagerBrowserTest.DevToolsNewDockedWindow [logdog] TaskManagerBrowserTest.DevToolsNewUndockedWindow [logdog] [ RUN ] TaskManagerBrowserTest.DevToolsNewDockedWindow [5788:3156:0830/231303:ERROR:interface_registry.cc(99)] Failed to locate a binder for interface: mojom::ResourceUsageReporter [2684:3924:0830/231304:FATAL:shared_sampler_win.cc(359)] Check failed: callbacks_map_.find(process_id) != callbacks_map_.end(). Backtrace: base::debug::StackTrace::StackTrace [0x1007ADC7+23] logging::LogMessage::~LogMessage [0x100C844B+59] task_manager::SharedSampler::Refresh [0x02F53EA3+435] task_manager::TaskGroup::Refresh [0x02F3E406+726] task_manager::TaskManagerImpl::Refresh [0x02C3E71A+170] ??$Invoke@PAVTaskManagerInterface@task_manager@@$$V@?$FunctorTraits@P8TaskManagerInterface@task_manager@@AEXXZX@internal@base@@SAXP8TaskManagerInterface@task_manager@@AEXXZ$$QAPAV34@@Z [0x02795822+18] base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall task_manager::TaskManagerInterface::*const &)(void),task_manager::TaskManagerInterface *> [0x02795884+36] base::internal::Invoker<base::internal::BindState<void (__thiscall task_manager::TaskManagerInterface::*)(void),base::internal::UnretainedWrapper<task_manager::TaskManagerInterface> >,void __cdecl(void)>::RunImpl<void (__thiscall task_manager::TaskManager [0x027958CB+59] base::internal::Invoker<base::internal::BindState<void (__thiscall task_manager::TaskManagerInterface::*)(void),base::internal::UnretainedWrapper<task_manager::TaskManagerInterface> >,void __cdecl(void)>::Run [0x02797C34+36] base::Callback<void __cdecl(void),1>::Run [0x1003F65E+30] base::Timer::RunScheduledTask [0x1023FF4B+203] base::BaseTimerTaskInternal::Run [0x1023FE68+56] ??$Invoke@PAVBaseTimerTaskInternal@base@@$$V@?$FunctorTraits@P8BaseTimerTaskInternal@base@@AEXXZX@internal@base@@SAXP8BaseTimerTaskInternal@2@AEXXZ$$QAPAV32@@Z [0x1023EF82+18] base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall base::BaseTimerTaskInternal::*const &)(void),base::BaseTimerTaskInternal *> [0x1023EFE4+36] base::internal::Invoker<base::internal::BindState<void (__thiscall base::BaseTimerTaskInternal::*)(void),base::internal::OwnedWrapper<base::BaseTimerTaskInternal> >,void __cdecl(void)>::RunImpl<void (__thiscall base::BaseTimerTaskInternal::*const &)(void) [0x1023F05B+59] base::internal::Invoker<base::internal::BindState<void (__thiscall base::BaseTimerTaskInternal::*)(void),base::internal::OwnedWrapper<base::BaseTimerTaskInternal> >,void __cdecl(void)>::Run [0x1023FE14+36] base::Callback<void __cdecl(void),1>::Run [0x1003F65E+30] base::debug::TaskAnnotator::RunTask [0x10080DE0+336] base::MessageLoop::RunTask [0x100EE3F0+640] base::MessageLoop::DeferOrRunPendingTask [0x100EC0EC+44] base::MessageLoop::DoDelayedWork [0x100EC54C+316] base::MessagePumpForUI::DoRunLoop [0x100F61D0+128] base::MessagePumpWin::Run [0x100F7D3B+123] base::MessageLoop::RunHandler [0x100EE131+193] base::RunLoop::Run [0x10192414+52] content::RunThisRunLoop [0x03522894+68] content::MessageLoopRunner::Run [0x03522580+208] DevToolsWindowTesting::WaitForDevToolsWindowLoad [0x00758E74+132] DevToolsWindowTesting::OpenDevToolsWindowSync [0x00758BE9+137] DevToolsWindowTesting::OpenDevToolsWindowSync [0x00758B4D+29] TaskManagerBrowserTest_DevToolsNewDockedWindow_Test::RunTestOnMainThread [0x00E4D79A+250] InProcessBrowserTest::RunTestOnMainThreadLoop [0x025E0D3D+605] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x03538EEE+206] ??$Invoke@PAVBrowserTestBase@content@@$$V@?$FunctorTraits@P8BrowserTestBase@content@@AEXXZX@internal@base@@SAXP8BrowserTestBase@content@@AEXXZ$$QAPAV34@@Z [0x035382A2+18] base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::BrowserTestBase::*const &)(void),content::BrowserTestBase *> [0x03538374+36] base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::RunImpl<void (__thiscall content::BrowserTestBase::*const &)(void),std [0x0353847B+59] base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::Run [0x03539264+36] base::Callback<void __cdecl(void),1>::Run [0x0063D88E+30] ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x030089A4+5828] ChromeBrowserMainParts::PreMainMessageLoopRun [0x03007284+244] content::BrowserMainLoop::PreMainMessageLoopRun [0x115D8D97+215] ??$Invoke@PAVBrowserMainLoop@content@@$$V@?$FunctorTraits@P8BrowserMainLoop@content@@AEHXZX@internal@base@@SAHP8BrowserMainLoop@content@@AEHXZ$$QAPAV34@@Z [0x115CF1F2+18] base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::BrowserMainLoop::*const &)(void),content::BrowserMainLoop *> [0x115CF584+36] base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::RunImpl<int (__thiscall content::BrowserMainLoop::*const &)(void),std::t [0x115CF72B+59] base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::Run [0x115D9244+36] base::Callback<int __cdecl(void),1>::Run [0x11CE68AE+30] content::StartupTaskRunner::RunAllTasksNow [0x121C5ACB+107] content::BrowserMainLoop::CreateStartupTasks [0x115D560F+591] content::BrowserMainRunnerImpl::Initialize [0x115DE9EE+958] content::BrowserMain [0x115CCF2F+95] content::RunNamedProcessTypeMain [0x13465447+135] content::ContentMainRunnerImpl::Run [0x13465308+488] content::ContentMain [0x13463144+100] content::BrowserTestBase::SetUp [0x03539846+1430] InProcessBrowserTest::SetUp [0x025E1222+738] ExtensionBrowserTest::SetUp [0x010B52CA+90] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x036A66A4+52] testing::Test::Run [0x036BA10D+77] testing::TestInfo::Run [0x036BA35D+173] testing::TestCase::Run [0x036BA23F+191] testing::internal::UnitTestImpl::RunAllTests [0x036BA765+661] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x036A6764+52] I am going to disable the tests as per sheriff instructions.
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a01d97dff593c530fe6b204421bdaa39252801e9 commit a01d97dff593c530fe6b204421bdaa39252801e9 Author: battre <battre@chromium.org> Date: Wed Aug 31 09:44:41 2016 Disable flaky TaskManagerBrowserTest.DevToolsNew{Und,D}ockedWindow tests BUG= 642482 TBR=stanisc@chromium.org,nick@chromium.org: Review-Url: https://codereview.chromium.org/2301493002 Cr-Commit-Position: refs/heads/master@{#415595} [modify] https://crrev.com/a01d97dff593c530fe6b204421bdaa39252801e9/chrome/browser/task_manager/task_manager_browsertest.cc
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a01d97dff593c530fe6b204421bdaa39252801e9 commit a01d97dff593c530fe6b204421bdaa39252801e9 Author: battre <battre@chromium.org> Date: Wed Aug 31 09:44:41 2016 Disable flaky TaskManagerBrowserTest.DevToolsNew{Und,D}ockedWindow tests BUG= 642482 TBR=stanisc@chromium.org,nick@chromium.org: Review-Url: https://codereview.chromium.org/2301493002 Cr-Commit-Position: refs/heads/master@{#415595} [modify] https://crrev.com/a01d97dff593c530fe6b204421bdaa39252801e9/chrome/browser/task_manager/task_manager_browsertest.cc
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/940f8f135b20b2e5bca8c76ad036eb98e142def0 commit 940f8f135b20b2e5bca8c76ad036eb98e142def0 Author: battre <battre@chromium.org> Date: Wed Aug 31 13:30:45 2016 Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage BUG= 642482 TBR=stanisc@chromium.org,nick@chromium.org Review-Url: https://codereview.chromium.org/2294113003 Cr-Commit-Position: refs/heads/master@{#415620} [modify] https://crrev.com/940f8f135b20b2e5bca8c76ad036eb98e142def0/chrome/browser/extensions/app_background_page_apitest.cc
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15ee7f73c882bb282d80225c50dd50c678438696 commit 15ee7f73c882bb282d80225c50dd50c678438696 Author: stanisc <stanisc@chromium.org> Date: Wed Aug 31 16:57:58 2016 Two TaskManager tests are flaky on debug due to a DCHECK in SharedSampler. This is happening due to a Refresh called from a task group which process_id is zero. I am not sure if calling Refresh when process_id is still zero should be supported. Perhaps that is an issue in TaskManagerImpl / TaskGroup code, I think https://crbug.com/521197 might be related. For now the quick fix is move the DCHECK a bit further in the code so it doesn't get triggered in that case. BUG= 642482 Review-Url: https://codereview.chromium.org/2293293002 Cr-Commit-Position: refs/heads/master@{#415663} [modify] https://crrev.com/15ee7f73c882bb282d80225c50dd50c678438696/chrome/browser/task_manager/sampling/shared_sampler_win.cc
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c01fc42411021d8ea86a8e19fc90edba153d92b3 commit c01fc42411021d8ea86a8e19fc90edba153d92b3 Author: stanisc <stanisc@chromium.org> Date: Wed Aug 31 20:49:19 2016 Revert of Disable flaky TaskManagerBrowserTest.DevToolsNew{Und,D}ockedWindow tests (patchset #1 id:1 of https://codereview.chromium.org/2301493002/ ) Reason for revert: The bug is now fixed so disabling these tests is no longer needed. See https://codereview.chromium.org/2293293002/ Original issue's description: > Disable flaky TaskManagerBrowserTest.DevToolsNew{Und,D}ockedWindow tests > > BUG= 642482 > TBR=stanisc@chromium.org,nick@chromium.org: > > Committed: https://crrev.com/a01d97dff593c530fe6b204421bdaa39252801e9 > Cr-Commit-Position: refs/heads/master@{#415595} TBR=nick@chromium.org,battre@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 642482 Review-Url: https://codereview.chromium.org/2298213003 Cr-Commit-Position: refs/heads/master@{#415747} [modify] https://crrev.com/c01fc42411021d8ea86a8e19fc90edba153d92b3/chrome/browser/task_manager/task_manager_browsertest.cc
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c224a65e52b3f824721e1d802faf87f239481823 commit c224a65e52b3f824721e1d802faf87f239481823 Author: stanisc <stanisc@chromium.org> Date: Wed Aug 31 20:54:23 2016 Revert of Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage (patchset #1 id:1 of https://codereview.chromium.org/2294113003/ ) Reason for revert: The bug is now fixed so disabling this test is no longer needed. See https://codereview.chromium.org/2293293002/ Original issue's description: > Disabled flaky test AppBackgroundPageApiTest.NoJsBackgroundPage > > BUG= 642482 > TBR=stanisc@chromium.org,nick@chromium.org > > Committed: https://crrev.com/940f8f135b20b2e5bca8c76ad036eb98e142def0 > Cr-Commit-Position: refs/heads/master@{#415620} TBR=nick@chromium.org,battre@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 642482 Review-Url: https://codereview.chromium.org/2299803002 Cr-Commit-Position: refs/heads/master@{#415749} [modify] https://crrev.com/c224a65e52b3f824721e1d802faf87f239481823/chrome/browser/extensions/app_background_page_apitest.cc
,
Sep 7 2016
,
Jan 24 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dgro...@chromium.org
, Aug 30 2016Status: Assigned (was: Untriaged)